Re: [PATCH v3 0/9] mirror: allow switching from background to active mode

2023-11-03 Thread Markus Armbruster
Fiona Ebner writes: > Am 18.10.23 um 11:41 schrieb Markus Armbruster: >> Fiona Ebner writes: >>> >>> Initially, I tried to go for a more general 'job-change' command, but >>> to avoid mutual inclusion of block-core.json and job.json, more >>> preparation would be required. >> >> Can you elabora

Re: [PATCH v3 0/9] mirror: allow switching from background to active mode

2023-10-25 Thread Kevin Wolf
Am 25.10.2023 um 14:27 hat Fiona Ebner geschrieben: > Am 23.10.23 um 13:39 schrieb Fiona Ebner: > > Am 19.10.23 um 15:36 schrieb Kevin Wolf: > >> Most of this series looks good to me. Apart from the comments I made in > >> the individual patches, I would like to see iotests coverage of changing > >

Re: [PATCH v3 0/9] mirror: allow switching from background to active mode

2023-10-25 Thread Fiona Ebner
Am 23.10.23 um 13:39 schrieb Fiona Ebner: > Am 19.10.23 um 15:36 schrieb Kevin Wolf: >> Most of this series looks good to me. Apart from the comments I made in >> the individual patches, I would like to see iotests coverage of changing >> the mirroring mode. At the least to show that the query resu

Re: [PATCH v3 0/9] mirror: allow switching from background to active mode

2023-10-23 Thread Fiona Ebner
Am 19.10.23 um 15:36 schrieb Kevin Wolf: > Most of this series looks good to me. Apart from the comments I made in > the individual patches, I would like to see iotests coverage of changing > the mirroring mode. At the least to show that the query result changes, > but ideally also that requests re

Re: [PATCH v3 0/9] mirror: allow switching from background to active mode

2023-10-19 Thread Kevin Wolf
Am 13.10.2023 um 11:21 hat Fiona Ebner geschrieben: > Changes in v3: > * unlock the job mutex when calling the new block job driver > 'query' handler > * squash patch adapting iotest output into patch that changes the > output > * turn accesses to copy_mode and actively_sync

Re: [PATCH v3 0/9] mirror: allow switching from background to active mode

2023-10-18 Thread Fiona Ebner
Am 18.10.23 um 11:41 schrieb Markus Armbruster: > Fiona Ebner writes: >> >> Initially, I tried to go for a more general 'job-change' command, but >> to avoid mutual inclusion of block-core.json and job.json, more >> preparation would be required. > > Can you elaborate a bit? A more generic comma

Re: [PATCH v3 0/9] mirror: allow switching from background to active mode

2023-10-18 Thread Markus Armbruster
Fiona Ebner writes: > Changes in v3: > * unlock the job mutex when calling the new block job driver > 'query' handler > * squash patch adapting iotest output into patch that changes the > output > * turn accesses to copy_mode and actively_synced atomic > * slightly rew

[PATCH v3 0/9] mirror: allow switching from background to active mode

2023-10-13 Thread Fiona Ebner
Changes in v3: * unlock the job mutex when calling the new block job driver 'query' handler * squash patch adapting iotest output into patch that changes the output * turn accesses to copy_mode and actively_synced atomic * slightly rework error handling in mirror_change