Re: [PATCH v3 0/2] hw/nvme: Add shadow doorbell buffer support

2022-06-26 Thread Klaus Jensen
On Jun 16 20:34, Jinhao Fan wrote: > This patch adds shadow doorbell buffer support in NVMe 1.3 to QEMU > NVMe. The Doorbell Buffer Config admin command is implemented for the > guest to enable shadow doobell buffer. When this feature is enabled, each > SQ/CQ is associated with two buffers, i.e., S

Re: [PATCH v3 0/2] hw/nvme: Add shadow doorbell buffer support

2022-06-17 Thread Keith Busch
On Thu, Jun 16, 2022 at 08:34:06PM +0800, Jinhao Fan wrote: > This patch adds shadow doorbell buffer support in NVMe 1.3 to QEMU > NVMe. The Doorbell Buffer Config admin command is implemented for the > guest to enable shadow doobell buffer. When this feature is enabled, each > SQ/CQ is associated

Re: [PATCH v3 0/2] hw/nvme: Add shadow doorbell buffer support

2022-06-17 Thread Jinhao Fan
> On Jun 17, 2022, at 8:56 PM, Klaus Jensen wrote: > > On Jun 17 20:47, Jinhao Fan wrote: >> >> >>> On Jun 17, 2022, at 7:54 PM, Klaus Jensen wrote: >>> >>> LGTM, >>> >>> Reviewed-by: Klaus Jensen >>> >> >> Great! >> >> I have two questions: >> >> How many “Reviewed-by”’s do I need to g

Re: [PATCH v3 0/2] hw/nvme: Add shadow doorbell buffer support

2022-06-17 Thread Klaus Jensen
On Jun 17 20:47, Jinhao Fan wrote: > > > > On Jun 17, 2022, at 7:54 PM, Klaus Jensen wrote: > > > > LGTM, > > > > Reviewed-by: Klaus Jensen > > > > Great! > > I have two questions: > > How many “Reviewed-by”’s do I need to get my patch applied? > That depends ;) The maintainers decide t

Re: [PATCH v3 0/2] hw/nvme: Add shadow doorbell buffer support

2022-06-17 Thread Jinhao Fan
> On Jun 17, 2022, at 7:54 PM, Klaus Jensen wrote: > > On Jun 16 20:34, Jinhao Fan wrote: >> This patch adds shadow doorbell buffer support in NVMe 1.3 to QEMU >> NVMe. The Doorbell Buffer Config admin command is implemented for the >> guest to enable shadow doobell buffer. When this feature i

Re: [PATCH v3 0/2] hw/nvme: Add shadow doorbell buffer support

2022-06-17 Thread Klaus Jensen
On Jun 16 20:34, Jinhao Fan wrote: > This patch adds shadow doorbell buffer support in NVMe 1.3 to QEMU > NVMe. The Doorbell Buffer Config admin command is implemented for the > guest to enable shadow doobell buffer. When this feature is enabled, each > SQ/CQ is associated with two buffers, i.e., S

[PATCH v3 0/2] hw/nvme: Add shadow doorbell buffer support

2022-06-16 Thread Jinhao Fan
This patch adds shadow doorbell buffer support in NVMe 1.3 to QEMU NVMe. The Doorbell Buffer Config admin command is implemented for the guest to enable shadow doobell buffer. When this feature is enabled, each SQ/CQ is associated with two buffers, i.e., Shadow Doorbell buffer and EventIdx buffer.