Re: [PATCH v3] win32: set threads name

2022-10-07 Thread Bin Meng
On Fri, Sep 30, 2022 at 10:19 PM wrote: > > From: Marc-André Lureau > > As described in: > https://learn.microsoft.com/en-us/visualstudio/debugger/how-to-set-a-thread-name-in-native-code?view=vs-2022 > > SetThreadDescription() is available since Windows 10, version 1607 and > in some versions onl

Re: [PATCH v3] win32: set threads name

2022-10-07 Thread Richard Henderson
On 10/7/22 02:52, Marc-André Lureau wrote: Hi On Fri, Oct 7, 2022 at 1:04 AM Richard Henderson > wrote: On 10/6/22 05:51, Marc-André Lureau wrote: > Hi Richard > > On Mon, Oct 3, 2022 at 11:39 AM Marc-André Lureau mailto:marcandre.lur...

Re: [PATCH v3] win32: set threads name

2022-10-07 Thread Marc-André Lureau
Hi On Fri, Oct 7, 2022 at 1:04 AM Richard Henderson < richard.hender...@linaro.org> wrote: > On 10/6/22 05:51, Marc-André Lureau wrote: > > Hi Richard > > > > On Mon, Oct 3, 2022 at 11:39 AM Marc-André Lureau < > marcandre.lur...@redhat.com > > > wrote: > > > >

Re: [PATCH v3] win32: set threads name

2022-10-06 Thread Richard Henderson
On 10/6/22 05:51, Marc-André Lureau wrote: Hi Richard On Mon, Oct 3, 2022 at 11:39 AM Marc-André Lureau > wrote: Hi On Fri, Sep 30, 2022 at 6:10 PM Richard Henderson mailto:richard.hender...@linaro.org>> wrote: > > On 9/30/22 07:03, ma

Re: [PATCH v3] win32: set threads name

2022-10-06 Thread Marc-André Lureau
Hi Richard On Mon, Oct 3, 2022 at 11:39 AM Marc-André Lureau < marcandre.lur...@redhat.com> wrote: > Hi > > On Fri, Sep 30, 2022 at 6:10 PM Richard Henderson > wrote: > > > > On 9/30/22 07:03, marcandre.lur...@redhat.com wrote: > > > +static bool > > > +set_thread_description(HANDLE h, const cha

Re: [PATCH v3] win32: set threads name

2022-10-03 Thread Marc-André Lureau
Hi On Fri, Sep 30, 2022 at 6:10 PM Richard Henderson wrote: > > On 9/30/22 07:03, marcandre.lur...@redhat.com wrote: > > +static bool > > +set_thread_description(HANDLE h, const char *name) > > +{ > > + HRESULT hr; > > + g_autofree wchar_t *namew = NULL; > > + > > + if (!load_set_thread_descri

Re: [PATCH v3] win32: set threads name

2022-10-03 Thread Marc-André Lureau
Hi Richard On Fri, Sep 30, 2022 at 6:10 PM Richard Henderson wrote: > > On 9/30/22 07:03, marcandre.lur...@redhat.com wrote: > > +static bool > > +set_thread_description(HANDLE h, const char *name) > > +{ > > + HRESULT hr; > > + g_autofree wchar_t *namew = NULL; > > + > > + if (!load_set_threa

Re: [PATCH v3] win32: set threads name

2022-09-30 Thread Richard Henderson
On 9/30/22 07:03, marcandre.lur...@redhat.com wrote: +static bool +set_thread_description(HANDLE h, const char *name) +{ + HRESULT hr; + g_autofree wchar_t *namew = NULL; + + if (!load_set_thread_description()) { + return false; + } I don't understand why you're retaining this. What is

[PATCH v3] win32: set threads name

2022-09-30 Thread marcandre . lureau
From: Marc-André Lureau As described in: https://learn.microsoft.com/en-us/visualstudio/debugger/how-to-set-a-thread-name-in-native-code?view=vs-2022 SetThreadDescription() is available since Windows 10, version 1607 and in some versions only by "Run Time Dynamic Linking". Its declaration is not