Re: [PATCH v3] virtio-serial-bus: Plug memory leak on realize() error paths

2020-03-09 Thread Amit Shah
On Mon, 2020-03-09 at 03:02 -0400, Michael S. Tsirkin wrote: > On Mon, Mar 09, 2020 at 10:17:38AM +0800, Pan Nengyuan wrote: > > We neglect to free port->bh on the error paths. Fix that. > > Reproducer: > > {'execute': 'device_add', 'arguments': {'id': > > 'virtio_serial_pci0', 'driver': 'virt

Re: [PATCH v3] virtio-serial-bus: Plug memory leak on realize() error paths

2020-03-09 Thread Markus Armbruster
"Michael S. Tsirkin" writes: > On Mon, Mar 09, 2020 at 10:17:38AM +0800, Pan Nengyuan wrote: >> We neglect to free port->bh on the error paths. Fix that. >> Reproducer: >> {'execute': 'device_add', 'arguments': {'id': 'virtio_serial_pci0', >> 'driver': 'virtio-serial-pci', 'bus': 'pci.0', '

Re: [PATCH v3] virtio-serial-bus: Plug memory leak on realize() error paths

2020-03-09 Thread Laurent Vivier
On 09/03/2020 03:17, Pan Nengyuan wrote: > We neglect to free port->bh on the error paths. Fix that. > Reproducer: > {'execute': 'device_add', 'arguments': {'id': 'virtio_serial_pci0', > 'driver': 'virtio-serial-pci', 'bus': 'pci.0', 'addr': '0x5'}, 'id': > 'yVkZcGgV'} > {'execute': 'dev

Re: [PATCH v3] virtio-serial-bus: Plug memory leak on realize() error paths

2020-03-09 Thread Michael S. Tsirkin
On Mon, Mar 09, 2020 at 10:17:38AM +0800, Pan Nengyuan wrote: > We neglect to free port->bh on the error paths. Fix that. > Reproducer: > {'execute': 'device_add', 'arguments': {'id': 'virtio_serial_pci0', > 'driver': 'virtio-serial-pci', 'bus': 'pci.0', 'addr': '0x5'}, 'id': > 'yVkZcGgV'} >

Re: [PATCH v3] virtio-serial-bus: Plug memory leak on realize() error paths

2020-03-08 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200309021738.30072-1-pannengy...@huawei.com/ Hi, This series failed the docker-clang@ubuntu build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN

[PATCH v3] virtio-serial-bus: Plug memory leak on realize() error paths

2020-03-08 Thread Pan Nengyuan
We neglect to free port->bh on the error paths. Fix that. Reproducer: {'execute': 'device_add', 'arguments': {'id': 'virtio_serial_pci0', 'driver': 'virtio-serial-pci', 'bus': 'pci.0', 'addr': '0x5'}, 'id': 'yVkZcGgV'} {'execute': 'device_add', 'arguments': {'id': 'port1', 'driver': 'vir