Re: [PATCH v3] test-vmstate: fix bad GTree usage, use-after-free

2023-02-28 Thread Eric Auger
Hi Daniel, On 2/28/23 10:12, Daniel P. Berrangé wrote: > On Tue, Feb 28, 2023 at 10:03:52AM +0100, Eric Auger wrote: >> According to g_tree_foreach() documentation: >> "The tree may not be modified while iterating over it (you can't >> add/remove items)." >> >> Since glib2 has removed its custom s

Re: [PATCH v3] test-vmstate: fix bad GTree usage, use-after-free

2023-02-28 Thread Daniel P . Berrangé
On Tue, Feb 28, 2023 at 10:03:52AM +0100, Eric Auger wrote: > According to g_tree_foreach() documentation: > "The tree may not be modified while iterating over it (you can't > add/remove items)." > > Since glib2 has removed its custom slice allocator and has switched > to using system malloc, a SI

[PATCH v3] test-vmstate: fix bad GTree usage, use-after-free

2023-02-28 Thread Eric Auger
According to g_tree_foreach() documentation: "The tree may not be modified while iterating over it (you can't add/remove items)." Since glib2 has removed its custom slice allocator and has switched to using system malloc, a SIGSEGV can be observed while running test-vmstate. With glibc + MALLOC_PE