Re: [PATCH v3] target-i386: Walk NPT in guest real mode

2024-11-05 Thread Alexander Graf
Hey Mark, On 05.11.24 23:54, Mark Cave-Ayland wrote: Hi Alex, This commit appears to break my WinXP boot test: with this patch applied, attempting to boot WinXP from CDROM fails with SeaBIOS getting stuck early in a boot loop. It is possible to reproduce the issue easily with:   ./build/qe

Re: [PATCH v3] target-i386: Walk NPT in guest real mode

2024-11-05 Thread Mark Cave-Ayland
On 21/09/2024 09:57, Alexander Graf wrote: When translating virtual to physical address with a guest CPU that supports nested paging (NPT), we need to perform every page table walk access indirectly through the NPT, which we correctly do. However, we treat real mode (no page table walk) special

Re: [PATCH v3] target-i386: Walk NPT in guest real mode

2024-10-21 Thread Richard Henderson
On 9/21/24 01:57, Alexander Graf wrote: When translating virtual to physical address with a guest CPU that supports nested paging (NPT), we need to perform every page table walk access indirectly through the NPT, which we correctly do. However, we treat real mode (no page table walk) special: In

[PATCH v3] target-i386: Walk NPT in guest real mode

2024-09-21 Thread Alexander Graf
When translating virtual to physical address with a guest CPU that supports nested paging (NPT), we need to perform every page table walk access indirectly through the NPT, which we correctly do. However, we treat real mode (no page table walk) special: In that case, we currently just skip any wal