Re: [PATCH v3] machine: add missing doc for memory-backend option

2021-02-05 Thread Igor Mammedov
On Thu, 4 Feb 2021 13:21:32 +0100 Michal Privoznik wrote: > On 1/21/21 5:15 PM, Igor Mammedov wrote: > > > > Ping, please? Is there anything I can help with to get this merged? > Libvirt's migration is broken without this patch [1] and thus I'd like > to have this merged sooner rather than

Re: [PATCH v3] machine: add missing doc for memory-backend option

2021-02-04 Thread Michal Privoznik
On 1/21/21 5:15 PM, Igor Mammedov wrote: > Ping, please? Is there anything I can help with to get this merged? Libvirt's migration is broken without this patch [1] and thus I'd like to have this merged sooner rather than later. 1: There's a libvirt patch required but depends on this one. Tha

Re: [PATCH v3] machine: add missing doc for memory-backend option

2021-01-27 Thread Igor Mammedov
On Wed, 27 Jan 2021 18:03:27 +0100 Michal Privoznik wrote: > On 1/27/21 4:35 PM, Igor Mammedov wrote: > > On Wed, 27 Jan 2021 15:24:26 +0100 > > Michal Privoznik wrote: > > > >> On 1/27/21 11:54 AM, Daniel P. Berrangé wrote: > >>> On Wed, Jan 27, 2021 at 10:45:11AM +, Daniel P. Berrangé

Re: [PATCH v3] machine: add missing doc for memory-backend option

2021-01-27 Thread Igor Mammedov
On Wed, 27 Jan 2021 18:41:46 + Daniel P. Berrangé wrote: > On Wed, Jan 27, 2021 at 07:30:24PM +0100, Michal Privoznik wrote: > > On 1/27/21 6:56 PM, Daniel P. Berrangé wrote: > > > On Wed, Jan 27, 2021 at 04:35:22PM +0100, Igor Mammedov wrote: > > > > On Wed, 27 Jan 2021 15:24:26 +0100 >

Re: [PATCH v3] machine: add missing doc for memory-backend option

2021-01-27 Thread Daniel P . Berrangé
On Wed, Jan 27, 2021 at 07:30:24PM +0100, Michal Privoznik wrote: > On 1/27/21 6:56 PM, Daniel P. Berrangé wrote: > > On Wed, Jan 27, 2021 at 04:35:22PM +0100, Igor Mammedov wrote: > > > On Wed, 27 Jan 2021 15:24:26 +0100 > > > Michal Privoznik wrote: > > > > > > > On 1/27/21 11:54 AM, Daniel P.

Re: [PATCH v3] machine: add missing doc for memory-backend option

2021-01-27 Thread Michal Privoznik
On 1/27/21 6:56 PM, Daniel P. Berrangé wrote: On Wed, Jan 27, 2021 at 04:35:22PM +0100, Igor Mammedov wrote: On Wed, 27 Jan 2021 15:24:26 +0100 Michal Privoznik wrote: On 1/27/21 11:54 AM, Daniel P. Berrangé wrote: On Wed, Jan 27, 2021 at 10:45:11AM +, Daniel P. Berrangé wrote: On Thu,

Re: [PATCH v3] machine: add missing doc for memory-backend option

2021-01-27 Thread Daniel P . Berrangé
On Wed, Jan 27, 2021 at 04:35:22PM +0100, Igor Mammedov wrote: > On Wed, 27 Jan 2021 15:24:26 +0100 > Michal Privoznik wrote: > > > On 1/27/21 11:54 AM, Daniel P. Berrangé wrote: > > > On Wed, Jan 27, 2021 at 10:45:11AM +, Daniel P. Berrangé wrote: > > >> On Thu, Jan 21, 2021 at 11:15:04AM

Re: [PATCH v3] machine: add missing doc for memory-backend option

2021-01-27 Thread Michal Privoznik
On 1/27/21 4:35 PM, Igor Mammedov wrote: On Wed, 27 Jan 2021 15:24:26 +0100 Michal Privoznik wrote: On 1/27/21 11:54 AM, Daniel P. Berrangé wrote: On Wed, Jan 27, 2021 at 10:45:11AM +, Daniel P. Berrangé wrote: On Thu, Jan 21, 2021 at 11:15:04AM -0500, Igor Mammedov wrote: How does

Re: [PATCH v3] machine: add missing doc for memory-backend option

2021-01-27 Thread Igor Mammedov
On Wed, 27 Jan 2021 15:24:26 +0100 Michal Privoznik wrote: > On 1/27/21 11:54 AM, Daniel P. Berrangé wrote: > > On Wed, Jan 27, 2021 at 10:45:11AM +, Daniel P. Berrangé wrote: > >> On Thu, Jan 21, 2021 at 11:15:04AM -0500, Igor Mammedov wrote: > > > >> > >> How does a mgmt app know whic

Re: [PATCH v3] machine: add missing doc for memory-backend option

2021-01-27 Thread Daniel P . Berrangé
On Wed, Jan 27, 2021 at 03:24:26PM +0100, Michal Privoznik wrote: > On 1/27/21 11:54 AM, Daniel P. Berrangé wrote: > > On Wed, Jan 27, 2021 at 10:45:11AM +, Daniel P. Berrangé wrote: > > > On Thu, Jan 21, 2021 at 11:15:04AM -0500, Igor Mammedov wrote: > > > > > > > > How does a mgmt app know

Re: [PATCH v3] machine: add missing doc for memory-backend option

2021-01-27 Thread Michal Privoznik
On 1/27/21 11:54 AM, Daniel P. Berrangé wrote: On Wed, Jan 27, 2021 at 10:45:11AM +, Daniel P. Berrangé wrote: On Thu, Jan 21, 2021 at 11:15:04AM -0500, Igor Mammedov wrote: How does a mgmt app know which machine types need to use this option ? The machine type names are opaque strings,

Re: [PATCH v3] machine: add missing doc for memory-backend option

2021-01-27 Thread Daniel P . Berrangé
On Wed, Jan 27, 2021 at 10:45:11AM +, Daniel P. Berrangé wrote: > On Thu, Jan 21, 2021 at 11:15:04AM -0500, Igor Mammedov wrote: > > Add documentation for '-machine memory-backend' CLI option and > > how to use it. > > > > And document that x-use-canonical-path-for-ramblock-id, > > is consider

Re: [PATCH v3] machine: add missing doc for memory-backend option

2021-01-27 Thread Daniel P . Berrangé
On Thu, Jan 21, 2021 at 11:15:04AM -0500, Igor Mammedov wrote: > Add documentation for '-machine memory-backend' CLI option and > how to use it. > > And document that x-use-canonical-path-for-ramblock-id, > is considered to be stable to make sure it won't go away by accident. > > x- was intended

Re: [PATCH v3] machine: add missing doc for memory-backend option

2021-01-27 Thread Michal Privoznik
On 1/21/21 5:15 PM, Igor Mammedov wrote: Add documentation for '-machine memory-backend' CLI option and how to use it. And document that x-use-canonical-path-for-ramblock-id, is considered to be stable to make sure it won't go away by accident. x- was intended for unstable/iternal properties, a

[PATCH v3] machine: add missing doc for memory-backend option

2021-01-21 Thread Igor Mammedov
Add documentation for '-machine memory-backend' CLI option and how to use it. And document that x-use-canonical-path-for-ramblock-id, is considered to be stable to make sure it won't go away by accident. x- was intended for unstable/iternal properties, and not supposed to be stable option. Howeve