Re: [PATCH v3] linux-user: implement execveat

2022-11-04 Thread Daniel P . Berrangé
On Fri, Nov 04, 2022 at 10:55:39AM +0100, Drew DeVault wrote: > On Fri Nov 4, 2022 at 10:53 AM CET, Philippe Mathieu-Daudé wrote: > > Splitting this big patch would ease review: > > It's only +165/-131, are you sure it really needs to be split? IMHO it is a standard best practice that code moveme

Re: [PATCH v3] linux-user: implement execveat

2022-11-04 Thread Laurent Vivier
Le 04/11/2022 à 10:55, Drew DeVault a écrit : On Fri Nov 4, 2022 at 10:53 AM CET, Philippe Mathieu-Daudé wrote: Splitting this big patch would ease review: It's only +165/-131, are you sure it really needs to be split? 1/ Replace safe_execve() by safe_execveat() -safe_execve(exec_path,

Re: [PATCH v3] linux-user: implement execveat

2022-11-04 Thread Philippe Mathieu-Daudé
On 4/11/22 10:55, Drew DeVault wrote: On Fri Nov 4, 2022 at 10:53 AM CET, Philippe Mathieu-Daudé wrote: Splitting this big patch would ease review: It's only +165/-131, are you sure it really needs to be split? I tend to ignore patches over 120 lines of change :) In this case it is about ex

Re: [PATCH v3] linux-user: implement execveat

2022-11-04 Thread Drew DeVault
On Fri Nov 4, 2022 at 10:53 AM CET, Philippe Mathieu-Daudé wrote: > Splitting this big patch would ease review: It's only +165/-131, are you sure it really needs to be split? > 1/ Replace safe_execve() by safe_execveat() > > -safe_execve(exec_path, argp, envp)) > +safe_execveat(AT_FDCWD,

Re: [PATCH v3] linux-user: implement execveat

2022-11-04 Thread Philippe Mathieu-Daudé
Hi Drew, On 3/11/22 18:32, Drew DeVault wrote: References: https://gitlab.com/qemu-project/qemu/-/issues/1007 Signed-off-by: Drew DeVault --- v2 => v3: - Rebase to address the is_proc_myself fix - Drop the ifdefs linux-user/syscall.c | 203 ++- 1 file

Re: [PATCH v3] linux-user: implement execveat

2022-11-03 Thread Helge Deller
On 11/3/22 18:32, Drew DeVault wrote: References: https://gitlab.com/qemu-project/qemu/-/issues/1007 Signed-off-by: Drew DeVault --- v2 => v3: - Rebase to address the is_proc_myself fix - Drop the ifdefs linux-user/syscall.c | 203 ++- 1 file changed,

[PATCH v3] linux-user: implement execveat

2022-11-03 Thread Drew DeVault
References: https://gitlab.com/qemu-project/qemu/-/issues/1007 Signed-off-by: Drew DeVault --- v2 => v3: - Rebase to address the is_proc_myself fix - Drop the ifdefs linux-user/syscall.c | 203 ++- 1 file changed, 105 insertions(+), 98 deletions(-) diff -