On Fri, Nov 04, 2022 at 10:55:39AM +0100, Drew DeVault wrote:
> On Fri Nov 4, 2022 at 10:53 AM CET, Philippe Mathieu-Daudé wrote:
> > Splitting this big patch would ease review:
>
> It's only +165/-131, are you sure it really needs to be split?
IMHO it is a standard best practice that code moveme
Le 04/11/2022 à 10:55, Drew DeVault a écrit :
On Fri Nov 4, 2022 at 10:53 AM CET, Philippe Mathieu-Daudé wrote:
Splitting this big patch would ease review:
It's only +165/-131, are you sure it really needs to be split?
1/ Replace safe_execve() by safe_execveat()
-safe_execve(exec_path,
On 4/11/22 10:55, Drew DeVault wrote:
On Fri Nov 4, 2022 at 10:53 AM CET, Philippe Mathieu-Daudé wrote:
Splitting this big patch would ease review:
It's only +165/-131, are you sure it really needs to be split?
I tend to ignore patches over 120 lines of change :)
In this case it is about ex
On Fri Nov 4, 2022 at 10:53 AM CET, Philippe Mathieu-Daudé wrote:
> Splitting this big patch would ease review:
It's only +165/-131, are you sure it really needs to be split?
> 1/ Replace safe_execve() by safe_execveat()
>
> -safe_execve(exec_path, argp, envp))
> +safe_execveat(AT_FDCWD,
Hi Drew,
On 3/11/22 18:32, Drew DeVault wrote:
References: https://gitlab.com/qemu-project/qemu/-/issues/1007
Signed-off-by: Drew DeVault
---
v2 => v3:
- Rebase to address the is_proc_myself fix
- Drop the ifdefs
linux-user/syscall.c | 203 ++-
1 file
On 11/3/22 18:32, Drew DeVault wrote:
References: https://gitlab.com/qemu-project/qemu/-/issues/1007
Signed-off-by: Drew DeVault
---
v2 => v3:
- Rebase to address the is_proc_myself fix
- Drop the ifdefs
linux-user/syscall.c | 203 ++-
1 file changed,
References: https://gitlab.com/qemu-project/qemu/-/issues/1007
Signed-off-by: Drew DeVault
---
v2 => v3:
- Rebase to address the is_proc_myself fix
- Drop the ifdefs
linux-user/syscall.c | 203 ++-
1 file changed, 105 insertions(+), 98 deletions(-)
diff -