Re: [PATCH v3] linux-user: Add guest memory layout to exception dump

2022-10-24 Thread Richard Henderson
On 10/25/22 15:24, Richard Henderson wrote: It would also fix a bug in that the host page permissions do not exactly match guest page permissions, and you're reporting host page permissions. Gah, not true, we've already probed page_flags. Reviewed-by: Richard Henderson r~

Re: [PATCH v3] linux-user: Add guest memory layout to exception dump

2022-10-24 Thread Richard Henderson
On 10/25/22 12:51, Helge Deller wrote: On 10/25/22 04:25, Richard Henderson wrote: On 10/25/22 11:57, Helge Deller wrote: On 10/25/22 00:35, Richard Henderson wrote: On 10/25/22 06:18, Helge Deller wrote: When the emulation stops with a hard exception it's very useful for debugging purposes t

Re: [PATCH v3] linux-user: Add guest memory layout to exception dump

2022-10-24 Thread Helge Deller
On 10/25/22 04:25, Richard Henderson wrote: On 10/25/22 11:57, Helge Deller wrote: On 10/25/22 00:35, Richard Henderson wrote: On 10/25/22 06:18, Helge Deller wrote: When the emulation stops with a hard exception it's very useful for debugging purposes to dump the current guest memory layout (

Re: [PATCH v3] linux-user: Add guest memory layout to exception dump

2022-10-24 Thread Richard Henderson
On 10/25/22 11:57, Helge Deller wrote: On 10/25/22 00:35, Richard Henderson wrote: On 10/25/22 06:18, Helge Deller wrote: When the emulation stops with a hard exception it's very useful for debugging purposes to dump the current guest memory layout (for an example see /proc/self/maps) beside th

Re: [PATCH v3] linux-user: Add guest memory layout to exception dump

2022-10-24 Thread Helge Deller
On 10/25/22 00:35, Richard Henderson wrote: On 10/25/22 06:18, Helge Deller wrote: When the emulation stops with a hard exception it's very useful for debugging purposes to dump the current guest memory layout (for an example see /proc/self/maps) beside the CPU registers. The open_self_maps() f

Re: [PATCH v3] linux-user: Add guest memory layout to exception dump

2022-10-24 Thread Richard Henderson
On 10/25/22 06:18, Helge Deller wrote: When the emulation stops with a hard exception it's very useful for debugging purposes to dump the current guest memory layout (for an example see /proc/self/maps) beside the CPU registers. The open_self_maps() function provides such a memory dump, but sinc

[PATCH v3] linux-user: Add guest memory layout to exception dump

2022-10-24 Thread Helge Deller
When the emulation stops with a hard exception it's very useful for debugging purposes to dump the current guest memory layout (for an example see /proc/self/maps) beside the CPU registers. The open_self_maps() function provides such a memory dump, but since it's located in the syscall.c file, var

Re: [PATCH v3] linux-user: Add guest memory layout to exception dump

2022-10-24 Thread Laurent Vivier
Le 24/10/2022 à 22:18, Helge Deller a écrit : When the emulation stops with a hard exception it's very useful for debugging purposes to dump the current guest memory layout (for an example see /proc/self/maps) beside the CPU registers. The open_self_maps() function provides such a memory dump, b