Re: [PATCH v3] intel-iommu: Document iova_tree

2023-01-09 Thread Peter Xu
On Mon, Jan 09, 2023 at 05:08:59PM +0800, Jason Wang wrote: > Either: > > 1) cropping in the memory core and remove the iommu cropping like > smmu_unmap_notifier_range() > > or > > 2) don't corp in the memory core but move smmu_unmap_notifier_range to > the core (still, a kind of implicit crop,

Re: [PATCH v3] intel-iommu: Document iova_tree

2023-01-09 Thread Jason Wang
On Wed, Jan 4, 2023 at 11:14 PM Peter Xu wrote: > > On Wed, Jan 04, 2023 at 12:15:20PM +0800, Jason Wang wrote: > > On Wed, Jan 4, 2023 at 1:30 AM Peter Xu wrote: > > > > > > On Mon, Dec 26, 2022 at 12:09:52PM +0800, Jason Wang wrote: > > > > On Sat, Dec 24, 2022 at 12:26 AM Peter Xu wrote: > >

Re: [PATCH v3] intel-iommu: Document iova_tree

2023-01-04 Thread Peter Xu
On Wed, Jan 04, 2023 at 12:15:20PM +0800, Jason Wang wrote: > On Wed, Jan 4, 2023 at 1:30 AM Peter Xu wrote: > > > > On Mon, Dec 26, 2022 at 12:09:52PM +0800, Jason Wang wrote: > > > On Sat, Dec 24, 2022 at 12:26 AM Peter Xu wrote: > > > > > > > > On Fri, Dec 23, 2022 at 03:48:01PM +0800, Jason W

Re: [PATCH v3] intel-iommu: Document iova_tree

2023-01-03 Thread Jason Wang
On Wed, Jan 4, 2023 at 1:30 AM Peter Xu wrote: > > On Mon, Dec 26, 2022 at 12:09:52PM +0800, Jason Wang wrote: > > On Sat, Dec 24, 2022 at 12:26 AM Peter Xu wrote: > > > > > > On Fri, Dec 23, 2022 at 03:48:01PM +0800, Jason Wang wrote: > > > > On Wed, Dec 7, 2022 at 6:13 AM Peter Xu wrote: > > >

Re: [PATCH v3] intel-iommu: Document iova_tree

2023-01-03 Thread Peter Xu
On Mon, Dec 26, 2022 at 12:09:52PM +0800, Jason Wang wrote: > On Sat, Dec 24, 2022 at 12:26 AM Peter Xu wrote: > > > > On Fri, Dec 23, 2022 at 03:48:01PM +0800, Jason Wang wrote: > > > On Wed, Dec 7, 2022 at 6:13 AM Peter Xu wrote: > > > > > > > > It seems not super clear on when iova_tree is use

Re: [PATCH v3] intel-iommu: Document iova_tree

2022-12-25 Thread Jason Wang
On Sat, Dec 24, 2022 at 12:26 AM Peter Xu wrote: > > On Fri, Dec 23, 2022 at 03:48:01PM +0800, Jason Wang wrote: > > On Wed, Dec 7, 2022 at 6:13 AM Peter Xu wrote: > > > > > > It seems not super clear on when iova_tree is used, and why. Add a rich > > > comment above iova_tree to track why we ne

Re: [PATCH v3] intel-iommu: Document iova_tree

2022-12-23 Thread Peter Xu
On Fri, Dec 23, 2022 at 03:48:01PM +0800, Jason Wang wrote: > On Wed, Dec 7, 2022 at 6:13 AM Peter Xu wrote: > > > > It seems not super clear on when iova_tree is used, and why. Add a rich > > comment above iova_tree to track why we needed the iova_tree, and when we > > need it. > > > > Also comm

Re: [PATCH v3] intel-iommu: Document iova_tree

2022-12-22 Thread Jason Wang
On Wed, Dec 7, 2022 at 6:13 AM Peter Xu wrote: > > It seems not super clear on when iova_tree is used, and why. Add a rich > comment above iova_tree to track why we needed the iova_tree, and when we > need it. > > Also comment for the map/unmap messages, on how they're used and > implications (e.

Re: [PATCH v3] intel-iommu: Document iova_tree

2022-12-07 Thread Eric Auger
Hi Peter, On 12/6/22 23:13, Peter Xu wrote: > It seems not super clear on when iova_tree is used, and why. Add a rich > comment above iova_tree to track why we needed the iova_tree, and when we > need it. > > Also comment for the map/unmap messages, on how they're used and > implications (e.g. un

[PATCH v3] intel-iommu: Document iova_tree

2022-12-06 Thread Peter Xu
It seems not super clear on when iova_tree is used, and why. Add a rich comment above iova_tree to track why we needed the iova_tree, and when we need it. Also comment for the map/unmap messages, on how they're used and implications (e.g. unmap can be larger than the mapped ranges). Suggested-by