Re: [PATCH v3] hw/rtc/mc146818rtc: Make this rtc device target independent

2022-12-29 Thread Thomas Huth
On 16/12/2022 15.26, Bernhard Beschow wrote: Am 12. Dezember 2022 07:56:00 UTC schrieb Thomas Huth : The only reason for this code being target dependent is the apic-related code in rtc_policy_slew_deliver_irq(). Since these apic functions are rather simple, we can easily move them into a new,

Re: [PATCH v3] hw/rtc/mc146818rtc: Make this rtc device target independent

2022-12-16 Thread Bernhard Beschow
Am 12. Dezember 2022 07:56:00 UTC schrieb Thomas Huth : >The only reason for this code being target dependent is the apic-related >code in rtc_policy_slew_deliver_irq(). Since these apic functions are rather >simple, we can easily move them into a new, separate file (apic_irqcount.c) >which will

Re: [PATCH v3] hw/rtc/mc146818rtc: Make this rtc device target independent

2022-12-12 Thread Mark Cave-Ayland
On 12/12/2022 13:48, Thomas Huth wrote: On 12/12/2022 14.39, Mark Cave-Ayland wrote: On 12/12/2022 07:56, Thomas Huth wrote: The only reason for this code being target dependent is the apic-related code in rtc_policy_slew_deliver_irq(). Since these apic functions are rather simple, we can eas

Re: [PATCH v3] hw/rtc/mc146818rtc: Make this rtc device target independent

2022-12-12 Thread Philippe Mathieu-Daudé
On 12/12/22 14:48, Thomas Huth wrote: On 12/12/2022 14.39, Mark Cave-Ayland wrote: On 12/12/2022 07:56, Thomas Huth wrote: The only reason for this code being target dependent is the apic-related code in rtc_policy_slew_deliver_irq(). Since these apic functions are rather simple, we can easil

Re: [PATCH v3] hw/rtc/mc146818rtc: Make this rtc device target independent

2022-12-12 Thread Thomas Huth
On 12/12/2022 14.39, Mark Cave-Ayland wrote: On 12/12/2022 07:56, Thomas Huth wrote: The only reason for this code being target dependent is the apic-related code in rtc_policy_slew_deliver_irq(). Since these apic functions are rather simple, we can easily move them into a new, separate file (a

Re: [PATCH v3] hw/rtc/mc146818rtc: Make this rtc device target independent

2022-12-12 Thread Mark Cave-Ayland
On 12/12/2022 07:56, Thomas Huth wrote: The only reason for this code being target dependent is the apic-related code in rtc_policy_slew_deliver_irq(). Since these apic functions are rather simple, we can easily move them into a new, separate file (apic_irqcount.c) which will always be compiled

Re: [PATCH v3] hw/rtc/mc146818rtc: Make this rtc device target independent

2022-12-12 Thread Philippe Mathieu-Daudé
On 12/12/22 08:56, Thomas Huth wrote: The only reason for this code being target dependent is the apic-related code in rtc_policy_slew_deliver_irq(). Since these apic functions are rather simple, we can easily move them into a new, separate file (apic_irqcount.c) which will always be compiled and

[PATCH v3] hw/rtc/mc146818rtc: Make this rtc device target independent

2022-12-11 Thread Thomas Huth
The only reason for this code being target dependent is the apic-related code in rtc_policy_slew_deliver_irq(). Since these apic functions are rather simple, we can easily move them into a new, separate file (apic_irqcount.c) which will always be compiled and linked if either APIC or the mc146818 d