Re: [PATCH v3] hw/net: fsl_etsec: Reverse the RCTRL.RSF logic

2021-02-11 Thread no-reply
/net: fsl_etsec: Reverse the RCTRL.RSF logic === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCR

Re: [PATCH v3] hw/net: fsl_etsec: Reverse the RCTRL.RSF logic

2021-02-09 Thread David Gibson
On Wed, Feb 10, 2021 at 10:10:21AM +0800, Bin Meng wrote: > From: Bin Meng > > Per MPC8548ERM [1] chapter 14.5.3.4.1: > > When RCTRL.RSF is 1, frames less than 64 bytes are accepted upon > a DA match. But currently QEMU does the opposite. This commit > reverses the RCTRL.RSF testing logic to mat

[PATCH v3] hw/net: fsl_etsec: Reverse the RCTRL.RSF logic

2021-02-09 Thread Bin Meng
From: Bin Meng Per MPC8548ERM [1] chapter 14.5.3.4.1: When RCTRL.RSF is 1, frames less than 64 bytes are accepted upon a DA match. But currently QEMU does the opposite. This commit reverses the RCTRL.RSF testing logic to match the manual. Due to the reverse of the logic, certain guests may pote