Re: [PATCH v3] hw/misc: applesmc: use host osk as default on macs

2022-04-21 Thread Vladislav Yaroshchuk
Hi, Daniel! Ok, thank you - then I'll wait until compat machines for 7.1 are added (after release) and send a new patch. Regards, Vladislav вт, 19 апр. 2022 г. в 19:03, Daniel P. Berrangé : > On Sun, Apr 17, 2022 at 04:43:14PM +0300, Vladislav Yaroshchuk wrote: > > I've CCed all the people from

Re: [PATCH v3] hw/misc: applesmc: use host osk as default on macs

2022-04-19 Thread Daniel P . Berrangé
On Sun, Apr 17, 2022 at 04:43:14PM +0300, Vladislav Yaroshchuk wrote: > I've CCed all the people from previous threads. > > > > [...] > > +static bool applesmc_read_osk(uint8_t *osk) > > +{ > > +#if defined(__APPLE__) && defined(__MACH__) > > +struct AppleSMCParams { > > +uint32_t key

Re: [PATCH v3] hw/misc: applesmc: use host osk as default on macs

2022-04-17 Thread Vladislav Yaroshchuk
I've CCed all the people from previous threads. > [...] > +static bool applesmc_read_osk(uint8_t *osk) > +{ > +#if defined(__APPLE__) && defined(__MACH__) > +struct AppleSMCParams { > +uint32_t key; > +uint8_t __pad0[16]; > +uint8_t result; > +uint8_t __pad1[7]

Re: [PATCH v3] hw/misc: applesmc: use host osk as default on macs

2022-04-16 Thread Vladislav Yaroshchuk
Hi Pedro Torres, Please note this threads https://patchew.org/QEMU/20211022161448.81579-1-yaroshchuk2...@gmail.com/ https://patchew.org/QEMU/20220113152836.60398-1-yaroshchuk2...@gmail.com/ There was a discussion about how to preserve backward compatibility of emulated AppleSMC behaviour. The dis

[PATCH v3] hw/misc: applesmc: use host osk as default on macs

2022-04-04 Thread Pedro Tôrres
From: Pedro Tôrres When running on a Mac, QEMU is able to get the host OSK and use it as the default value for the AppleSMC device. The OSK query operation doesn't require administrator privileges and can be executed by any user on the system. This patch is based on Phil Dennis-Jordan's descript