Re: [PATCH v3] hw/cxl: Add QTG _DSM support for ACPI0017 device

2023-10-09 Thread Jonathan Cameron via
On Fri, 6 Oct 2023 10:50:28 -0700 Dan Williams wrote: > Jonathan Cameron wrote: > [..] > > > > > > > > > > what does "a WORD" mean is unclear - do you match what hardware does > > > > > when you use aml_buffer? pls mention this in commit log, and > > > > > show actual hardware dump for compariso

Re: [PATCH v3] hw/cxl: Add QTG _DSM support for ACPI0017 device

2023-10-09 Thread Jonathan Cameron via
On Sat, 7 Oct 2023 17:17:44 -0400 "Michael S. Tsirkin" wrote: > On Fri, Oct 06, 2023 at 01:09:39PM +0100, Jonathan Cameron wrote: > > On Thu, 5 Oct 2023 12:32:11 -0400 > > "Michael S. Tsirkin" wrote: > > > > > On Thu, Oct 05, 2023 at 09:11:15AM -0700, Dave Jiang wrote: > > > > > > > > > >

Re: [PATCH v3] hw/cxl: Add QTG _DSM support for ACPI0017 device

2023-10-07 Thread Michael S. Tsirkin
On Fri, Oct 06, 2023 at 01:09:39PM +0100, Jonathan Cameron wrote: > On Thu, 5 Oct 2023 12:32:11 -0400 > "Michael S. Tsirkin" wrote: > > > On Thu, Oct 05, 2023 at 09:11:15AM -0700, Dave Jiang wrote: > > > > > > > > > On 10/4/23 20:36, Michael S. Tsirkin wrote: > > > > > > > > On Wed, Oct 04,

Re: [PATCH v3] hw/cxl: Add QTG _DSM support for ACPI0017 device

2023-10-06 Thread Dan Williams
Jonathan Cameron wrote: [..] > > > > > > > > what does "a WORD" mean is unclear - do you match what hardware does > > > > when you use aml_buffer? pls mention this in commit log, and > > > > show actual hardware dump for comparison. > > > The CXL spec says WORD without much qualification. It's a

Re: [PATCH v3] hw/cxl: Add QTG _DSM support for ACPI0017 device

2023-10-06 Thread Jonathan Cameron via
On Thu, 5 Oct 2023 12:32:11 -0400 "Michael S. Tsirkin" wrote: > On Thu, Oct 05, 2023 at 09:11:15AM -0700, Dave Jiang wrote: > > > > > > On 10/4/23 20:36, Michael S. Tsirkin wrote: > > > > > > On Wed, Oct 04, 2023 at 04:09:07PM -0700, Dave Jiang wrote: > > >> Add a simple _DSM call support

Re: [PATCH v3] hw/cxl: Add QTG _DSM support for ACPI0017 device

2023-10-05 Thread Michael S. Tsirkin
On Thu, Oct 05, 2023 at 09:11:15AM -0700, Dave Jiang wrote: > > > On 10/4/23 20:36, Michael S. Tsirkin wrote: > > > > On Wed, Oct 04, 2023 at 04:09:07PM -0700, Dave Jiang wrote: > >> Add a simple _DSM call support for the ACPI0017 device to return a fake QTG > >> ID value of 0 in all cases. The

Re: [PATCH v3] hw/cxl: Add QTG _DSM support for ACPI0017 device

2023-10-05 Thread Michael S. Tsirkin
On Thu, Oct 05, 2023 at 09:11:15AM -0700, Dave Jiang wrote: > > > On 10/4/23 20:36, Michael S. Tsirkin wrote: > > > > On Wed, Oct 04, 2023 at 04:09:07PM -0700, Dave Jiang wrote: > >> Add a simple _DSM call support for the ACPI0017 device to return a fake QTG > >> ID value of 0 in all cases. The

Re: [PATCH v3] hw/cxl: Add QTG _DSM support for ACPI0017 device

2023-10-05 Thread Dave Jiang
On 10/4/23 20:36, Michael S. Tsirkin wrote: > > On Wed, Oct 04, 2023 at 04:09:07PM -0700, Dave Jiang wrote: >> Add a simple _DSM call support for the ACPI0017 device to return a fake QTG >> ID value of 0 in all cases. The enabling is for _DSM plumbing testing >> from the OS. > > > the enablin

Re: [PATCH v3] hw/cxl: Add QTG _DSM support for ACPI0017 device

2023-10-04 Thread Michael S. Tsirkin
On Wed, Oct 04, 2023 at 04:09:07PM -0700, Dave Jiang wrote: > Add a simple _DSM call support for the ACPI0017 device to return a fake QTG > ID value of 0 in all cases. The enabling is for _DSM plumbing testing > from the OS. the enabling -> this > > Following edited for readbility only readb

[PATCH v3] hw/cxl: Add QTG _DSM support for ACPI0017 device

2023-10-04 Thread Dave Jiang
Add a simple _DSM call support for the ACPI0017 device to return a fake QTG ID value of 0 in all cases. The enabling is for _DSM plumbing testing from the OS. Following edited for readbility only Device (CXLM) { Name (_HID, "ACPI0017") // _HID: Hardware ID ... Method (_DSM, 4, Serialized