Re: [PATCH v3] hw/arm: do not free machine->fdt in arm_load_dtb()

2023-03-30 Thread Daniel Henrique Barboza
On 3/30/23 08:58, Alexander Bulekov wrote: On 230328 1859, Markus Armbruster wrote: At this moment, arm_load_dtb() can free machine->fdt when binfo->dtb_filename is NULL. If there's no 'dtb_filename', 'fdt' will be retrieved by binfo->get_dtb(). If get_dtb() returns machine->fdt, as is the ca

Re: [PATCH v3] hw/arm: do not free machine->fdt in arm_load_dtb()

2023-03-30 Thread Alexander Bulekov
On 230328 1859, Markus Armbruster wrote: > At this moment, arm_load_dtb() can free machine->fdt when > binfo->dtb_filename is NULL. If there's no 'dtb_filename', 'fdt' will be > retrieved by binfo->get_dtb(). If get_dtb() returns machine->fdt, as is > the case of machvirt_dtb() from hw/arm/virt.c,

Re: [PATCH v3] hw/arm: do not free machine->fdt in arm_load_dtb()

2023-03-30 Thread Peter Maydell
On Tue, 28 Mar 2023 at 17:59, Markus Armbruster wrote: > > At this moment, arm_load_dtb() can free machine->fdt when > binfo->dtb_filename is NULL. If there's no 'dtb_filename', 'fdt' will be > retrieved by binfo->get_dtb(). If get_dtb() returns machine->fdt, as is > the case of machvirt_dtb() fro

Re: [PATCH v3] hw/arm: do not free machine->fdt in arm_load_dtb()

2023-03-28 Thread Daniel Henrique Barboza
On 3/28/23 13:59, Markus Armbruster wrote: At this moment, arm_load_dtb() can free machine->fdt when binfo->dtb_filename is NULL. If there's no 'dtb_filename', 'fdt' will be retrieved by binfo->get_dtb(). If get_dtb() returns machine->fdt, as is the case of machvirt_dtb() from hw/arm/virt.c, f

[PATCH v3] hw/arm: do not free machine->fdt in arm_load_dtb()

2023-03-28 Thread Markus Armbruster
At this moment, arm_load_dtb() can free machine->fdt when binfo->dtb_filename is NULL. If there's no 'dtb_filename', 'fdt' will be retrieved by binfo->get_dtb(). If get_dtb() returns machine->fdt, as is the case of machvirt_dtb() from hw/arm/virt.c, fdt now has a pointer to machine->fdt. And, in th