Re: [PATCH v26 03/17] vfio: Add save and load functions for VFIO PCI devices

2020-10-21 Thread Alex Williamson
On Wed, 21 Oct 2020 17:30:04 +0800 Zenghui Yu wrote: > On 2020/9/25 6:49, Alex Williamson wrote: > >> +} else if (interrupt_type == VFIO_INT_MSIX) { > >> +uint16_t offset; > >> + > >> +msix_load(pdev, f); > >> +offset = pci_default_read_config(pdev, > >> +

Re: [PATCH v26 03/17] vfio: Add save and load functions for VFIO PCI devices

2020-10-21 Thread Zenghui Yu
On 2020/9/25 6:49, Alex Williamson wrote: +} else if (interrupt_type == VFIO_INT_MSIX) { +uint16_t offset; + +msix_load(pdev, f); +offset = pci_default_read_config(pdev, + pdev->msix_cap + PCI_MSIX_FLAGS + 1, 2); +/* load e

Re: [PATCH v26 03/17] vfio: Add save and load functions for VFIO PCI devices

2020-09-24 Thread Alex Williamson
On Wed, 23 Sep 2020 04:54:05 +0530 Kirti Wankhede wrote: > These functions save and restore PCI device specific data - config > space of PCI device. > Used VMStateDescription to save and restore interrupt state. > > Signed-off-by: Kirti Wankhede > Reviewed-by: Neo Jia > --- > hw/vfio/pci.c

Re: [PATCH v26 03/17] vfio: Add save and load functions for VFIO PCI devices

2020-09-22 Thread Zenghui Yu
Hi Kirti, A few trivial comments from the first read through. On 2020/9/23 7:24, Kirti Wankhede wrote: These functions save and restore PCI device specific data - config space of PCI device. Used VMStateDescription to save and restore interrupt state. Signed-off-by: Kirti Wankhede Reviewed-by

[PATCH v26 03/17] vfio: Add save and load functions for VFIO PCI devices

2020-09-22 Thread Kirti Wankhede
These functions save and restore PCI device specific data - config space of PCI device. Used VMStateDescription to save and restore interrupt state. Signed-off-by: Kirti Wankhede Reviewed-by: Neo Jia --- hw/vfio/pci.c | 134 ++ hw/vfio/pci