Re: [PATCH v2 for-7.1 6/9] nbd: code motion and function renaming

2022-04-23 Thread Paolo Bonzini
On 4/16/22 14:37, Vladimir Sementsov-Ogievskiy wrote: 14.04.2022 20:57, Paolo Bonzini wrote: Prepare for the next patch, so that the diff is less confusing. nbd_client_connecting is moved closer to the definition point. Amm. To usage-point you mean? The original idea was to keep simple state-

Re: [PATCH v2 for-7.1 6/9] nbd: code motion and function renaming

2022-04-16 Thread Vladimir Sementsov-Ogievskiy
14.04.2022 20:57, Paolo Bonzini wrote: Prepare for the next patch, so that the diff is less confusing. nbd_client_connecting is moved closer to the definition point. Amm. To usage-point you mean? The original idea was to keep simple state-reading helpers definitions together :) nbd_client_

Re: [PATCH v2 for-7.1 6/9] nbd: code motion and function renaming

2022-04-14 Thread Eric Blake
On Thu, Apr 14, 2022 at 07:57:53PM +0200, Paolo Bonzini wrote: > Prepare for the next patch, so that the diff is less confusing. > > nbd_client_connecting is moved closer to the definition point. > > nbd_client_connecting_wait() is kept only for the reconnection > logic; when it is used to check

[PATCH v2 for-7.1 6/9] nbd: code motion and function renaming

2022-04-14 Thread Paolo Bonzini
Prepare for the next patch, so that the diff is less confusing. nbd_client_connecting is moved closer to the definition point. nbd_client_connecting_wait() is kept only for the reconnection logic; when it is used to check if a request has to be reissued, use the renamed function nbd_client_will_r