Re: [PATCH v2 for-7.1 3/9] nbd: remove peppering of nbd_client_connected

2022-04-23 Thread Paolo Bonzini
Hi, thanks for the careful review and sorry I'm only replying now. On 4/15/22 19:01, Vladimir Sementsov-Ogievskiy wrote: @@ -982,11 +978,6 @@ static bool nbd_reply_chunk_iter_receive(BDRVNBDState *s,   NBDReply local_reply;   NBDStructuredReplyChunk *chunk;   Error *local_err = NUL

Re: [PATCH v2 for-7.1 3/9] nbd: remove peppering of nbd_client_connected

2022-04-15 Thread Vladimir Sementsov-Ogievskiy
14.04.2022 20:57, Paolo Bonzini wrote: It is unnecessary to check nbd_client_connected() because every time s->state is moved out of NBD_CLIENT_CONNECTED the socket is shut down and all coroutines are resumed. The only case where it was actually needed is when the NBD server disconnects and ther

[PATCH v2 for-7.1 3/9] nbd: remove peppering of nbd_client_connected

2022-04-14 Thread Paolo Bonzini
It is unnecessary to check nbd_client_connected() because every time s->state is moved out of NBD_CLIENT_CONNECTED the socket is shut down and all coroutines are resumed. The only case where it was actually needed is when the NBD server disconnects and there is no reconnect-delay. In that case, n