Re: [PATCH v2 for-7.1 1/9] nbd: safeguard against waking up invalid coroutine

2022-04-15 Thread Vladimir Sementsov-Ogievskiy
14.04.2022 20:57, Paolo Bonzini wrote: The .reply_possible field of s->requests is never set to false. This is not a problem as it is only a safeguard to detect protocol errors, but it's sloppy. In fact, the field is actually not necessary at all, because .coroutine is set to NULL in NBD_FOREAC

Re: [PATCH v2 for-7.1 1/9] nbd: safeguard against waking up invalid coroutine

2022-04-14 Thread Eric Blake
On Thu, Apr 14, 2022 at 07:57:48PM +0200, Paolo Bonzini wrote: > The .reply_possible field of s->requests is never set to false. This is > not a problem as it is only a safeguard to detect protocol errors, > but it's sloppy. In fact, the field is actually not necessary at all, > because .coroutin

[PATCH v2 for-7.1 1/9] nbd: safeguard against waking up invalid coroutine

2022-04-14 Thread Paolo Bonzini
The .reply_possible field of s->requests is never set to false. This is not a problem as it is only a safeguard to detect protocol errors, but it's sloppy. In fact, the field is actually not necessary at all, because .coroutine is set to NULL in NBD_FOREACH_REPLY_CHUNK after receiving the last ch