Re: [PATCH v2 8/8] hw/misc/vmcoreinfo: Add comment about reset handler

2019-10-09 Thread Li Qiang
Philippe Mathieu-Daudé 于2019年10月8日周二 下午10:40写道: > The VM coreinfo device does not sit on a bus, so it won't be > reset automatically. This is why it calls qemu_register_reset(). > > Add a comment about it, so we don't convert its reset handler > to a DeviceReset method. > > Signed-off-by: Philipp

Re: [PATCH v2 8/8] hw/misc/vmcoreinfo: Add comment about reset handler

2019-10-08 Thread Marc-André Lureau
On Tue, Oct 8, 2019 at 6:35 PM Philippe Mathieu-Daudé wrote: > > The VM coreinfo device does not sit on a bus, so it won't be > reset automatically. This is why it calls qemu_register_reset(). > > Add a comment about it, so we don't convert its reset handler > to a DeviceReset method. > > Signed-o

[PATCH v2 8/8] hw/misc/vmcoreinfo: Add comment about reset handler

2019-10-08 Thread Philippe Mathieu-Daudé
The VM coreinfo device does not sit on a bus, so it won't be reset automatically. This is why it calls qemu_register_reset(). Add a comment about it, so we don't convert its reset handler to a DeviceReset method. Signed-off-by: Philippe Mathieu-Daudé --- hw/misc/vmcoreinfo.c | 4 1 file ch