Re: [PATCH v2 8/8] hw/cxl/events: Add in inject general media event

2023-01-12 Thread Jonathan Cameron via
On Wed, 21 Dec 2022 20:24:38 -0800 Ira Weiny wrote: > To facilitate testing provide a QMP command to inject a general media > event. The event can be added to the log specified. > > Signed-off-by: Ira Weiny Hi Ira, One thing inline that kind of came out of Philippe's review of the earlier cle

Re: [PATCH v2 8/8] hw/cxl/events: Add in inject general media event

2023-01-11 Thread Jonathan Cameron via
> > > From an interface cleanliness point of view I'd rather see > > > all the optional fields as optional. That's done by marking them > > > with a * so > > > '*channel': 'int16' > > > > > > Then the signature of the related qmp_cxl_inject_gen_media_event > > > gains a boolean has_channel para

Re: [PATCH v2 8/8] hw/cxl/events: Add in inject general media event

2023-01-10 Thread Jonathan Cameron via
On Mon, 9 Jan 2023 11:15:28 -0800 Ira Weiny wrote: > On Tue, Jan 03, 2023 at 06:07:19PM +, Jonathan Cameron wrote: > > On Wed, 21 Dec 2022 20:24:38 -0800 > > Ira Weiny wrote: > > > > > To facilitate testing provide a QMP command to inject a general media > > > event. The event can be add

Re: [PATCH v2 8/8] hw/cxl/events: Add in inject general media event

2023-01-09 Thread Ira Weiny
On Tue, Jan 03, 2023 at 06:07:19PM +, Jonathan Cameron wrote: > On Wed, 21 Dec 2022 20:24:38 -0800 > Ira Weiny wrote: > > > To facilitate testing provide a QMP command to inject a general media > > event. The event can be added to the log specified. > > > > Signed-off-by: Ira Weiny > > Hi

Re: [PATCH v2 8/8] hw/cxl/events: Add in inject general media event

2023-01-03 Thread Jonathan Cameron via
On Wed, 21 Dec 2022 20:24:38 -0800 Ira Weiny wrote: > To facilitate testing provide a QMP command to inject a general media > event. The event can be added to the log specified. > > Signed-off-by: Ira Weiny Hi Ira, Suggestion inline on how to more neatly handle optional arguments using QMPs

[PATCH v2 8/8] hw/cxl/events: Add in inject general media event

2022-12-21 Thread Ira Weiny
To facilitate testing provide a QMP command to inject a general media event. The event can be added to the log specified. Signed-off-by: Ira Weiny --- Changes from RFC: Add all fields for this event irq happens automatically when log transitions from 0 to 1 --- hw/mem/cxl_type3