Re: [PATCH v2 7/8] hw/arm/virt: Fix devicetree warnings about the virtio-iommu node

2022-10-24 Thread Peter Maydell
On Fri, 21 Oct 2022 at 15:33, Jean-Philippe Brucker wrote: > > On Tue, Sep 27, 2022 at 04:35:25PM +0200, Eric Auger wrote: > > >> diff --git a/hw/arm/virt.c b/hw/arm/virt.c > > >> index 2de16f6324..5e16d54bbb 100644 > > >> --- a/hw/arm/virt.c > > >> +++ b/hw/arm/virt.c > > >> @@ -1372,14 +1372,15

Re: [PATCH v2 7/8] hw/arm/virt: Fix devicetree warnings about the virtio-iommu node

2022-10-21 Thread Jean-Philippe Brucker
On Tue, Sep 27, 2022 at 04:35:25PM +0200, Eric Auger wrote: > >> diff --git a/hw/arm/virt.c b/hw/arm/virt.c > >> index 2de16f6324..5e16d54bbb 100644 > >> --- a/hw/arm/virt.c > >> +++ b/hw/arm/virt.c > >> @@ -1372,14 +1372,15 @@ static void create_smmu(const VirtMachineState > >> *vms, > >> > >> s

Re: [PATCH v2 7/8] hw/arm/virt: Fix devicetree warnings about the virtio-iommu node

2022-09-27 Thread Eric Auger
Hi, On 9/27/22 13:46, Peter Maydell wrote: > On Tue, 27 Sept 2022 at 11:12, Jean-Philippe Brucker > wrote: >> >> The "PCI Bus Binding to: IEEE Std 1275-1994" defines the compatible >> string for a PCIe bus or endpoint as "pci," or >> similar. Since the initial binding for PCI virtio-iommu didn't

Re: [PATCH v2 7/8] hw/arm/virt: Fix devicetree warnings about the virtio-iommu node

2022-09-27 Thread Peter Maydell
On Tue, 27 Sept 2022 at 11:12, Jean-Philippe Brucker wrote: > > The "PCI Bus Binding to: IEEE Std 1275-1994" defines the compatible > string for a PCIe bus or endpoint as "pci," or > similar. Since the initial binding for PCI virtio-iommu didn't follow > this rule, it was modified to accept both s

[PATCH v2 7/8] hw/arm/virt: Fix devicetree warnings about the virtio-iommu node

2022-09-27 Thread Jean-Philippe Brucker
The "PCI Bus Binding to: IEEE Std 1275-1994" defines the compatible string for a PCIe bus or endpoint as "pci," or similar. Since the initial binding for PCI virtio-iommu didn't follow this rule, it was modified to accept both strings and ensure backward compatibility. Also, the unit-name for the n