Re: [PATCH v2 7/7] hw/arm: Add ID for NPCM7XX SMBus

2021-11-03 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > +Markus/Eduardo > > On 11/1/21 18:33, Peter Maydell wrote: >> On Thu, 21 Oct 2021 at 19:40, Hao Wu wrote: >>> >>> The ID can be used to indicate SMBus modules when adding >>> dynamic devices to them. >>> >>> Signed-off-by: Hao Wu >>> --- >>> hw/arm/npcm7xx.c |

Re: [PATCH v2 7/7] hw/arm: Add ID for NPCM7XX SMBus

2021-11-02 Thread Philippe Mathieu-Daudé
+Markus/Eduardo On 11/1/21 18:33, Peter Maydell wrote: > On Thu, 21 Oct 2021 at 19:40, Hao Wu wrote: >> >> The ID can be used to indicate SMBus modules when adding >> dynamic devices to them. >> >> Signed-off-by: Hao Wu >> --- >> hw/arm/npcm7xx.c | 1 + >> 1 file changed, 1 insertion(+) >> >> d

Re: [PATCH v2 7/7] hw/arm: Add ID for NPCM7XX SMBus

2021-11-01 Thread Hao Wu
I was trying to allow attaching a device using "-device xxx,bus=smbus[0]" Maybe there's a better way to allow that? I guess I can drop this one from the patch set. On Mon, Nov 1, 2021 at 10:33 AM Peter Maydell wrote: > On Thu, 21 Oct 2021 at 19:40, Hao Wu wrote: > > > > The ID can be used to i

Re: [PATCH v2 7/7] hw/arm: Add ID for NPCM7XX SMBus

2021-11-01 Thread Peter Maydell
On Thu, 21 Oct 2021 at 19:40, Hao Wu wrote: > > The ID can be used to indicate SMBus modules when adding > dynamic devices to them. > > Signed-off-by: Hao Wu > --- > hw/arm/npcm7xx.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/hw/arm/npcm7xx.c b/hw/arm/npcm7xx.c > index 2ab0080e0b..

[PATCH v2 7/7] hw/arm: Add ID for NPCM7XX SMBus

2021-10-21 Thread Hao Wu
The ID can be used to indicate SMBus modules when adding dynamic devices to them. Signed-off-by: Hao Wu --- hw/arm/npcm7xx.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/arm/npcm7xx.c b/hw/arm/npcm7xx.c index 2ab0080e0b..72953d65ef 100644 --- a/hw/arm/npcm7xx.c +++ b/hw/arm/npcm7xx.c @