Re: [PATCH v2 6/7] block/copy-before-write: implement cbw-timeout option

2022-04-01 Thread Vladimir Sementsov-Ogievskiy
01.04.2022 16:28, Hanna Reitz wrote: On 01.04.22 15:24, Hanna Reitz wrote: On 01.04.22 11:19, Vladimir Sementsov-Ogievskiy wrote: In some scenarios, when copy-before-write operations lasts too long time, it's better to cancel it. Most useful would be to use the new option together with on-cbw-

Re: [PATCH v2 6/7] block/copy-before-write: implement cbw-timeout option

2022-04-01 Thread Hanna Reitz
On 01.04.22 15:24, Hanna Reitz wrote: On 01.04.22 11:19, Vladimir Sementsov-Ogievskiy wrote: In some scenarios, when copy-before-write operations lasts too long time, it's better to cancel it. Most useful would be to use the new option together with on-cbw-error=break-snapshot: this way if cbw

Re: [PATCH v2 6/7] block/copy-before-write: implement cbw-timeout option

2022-04-01 Thread Hanna Reitz
On 01.04.22 11:19, Vladimir Sementsov-Ogievskiy wrote: In some scenarios, when copy-before-write operations lasts too long time, it's better to cancel it. Most useful would be to use the new option together with on-cbw-error=break-snapshot: this way if cbw operation takes too long time we'll jus

[PATCH v2 6/7] block/copy-before-write: implement cbw-timeout option

2022-04-01 Thread Vladimir Sementsov-Ogievskiy
In some scenarios, when copy-before-write operations lasts too long time, it's better to cancel it. Most useful would be to use the new option together with on-cbw-error=break-snapshot: this way if cbw operation takes too long time we'll just cancel backup process but do not disturb the guest too