Re: [PATCH v2 5/6] qapi: device-sync-config: check runstate

2024-03-07 Thread Vladimir Sementsov-Ogievskiy
On 07.03.24 12:57, Markus Armbruster wrote: Vladimir Sementsov-Ogievskiy writes: Command result is racy if allow it during migration. Let's allow the sync only in RUNNING state. Signed-off-by: Vladimir Sementsov-Ogievskiy If I understand this correctly, the previous commit introduces a rac

Re: [PATCH v2 5/6] qapi: device-sync-config: check runstate

2024-03-07 Thread Markus Armbruster
Vladimir Sementsov-Ogievskiy writes: > Command result is racy if allow it during migration. Let's allow the > sync only in RUNNING state. > > Signed-off-by: Vladimir Sementsov-Ogievskiy If I understand this correctly, the previous commit introduces a race, and this one fixes it. We normally av

[PATCH v2 5/6] qapi: device-sync-config: check runstate

2024-03-01 Thread Vladimir Sementsov-Ogievskiy
Command result is racy if allow it during migration. Let's allow the sync only in RUNNING state. Signed-off-by: Vladimir Sementsov-Ogievskiy --- include/sysemu/runstate.h | 1 + system/qdev-monitor.c | 27 ++- system/runstate.c | 5 + 3 files changed, 32