Re: [PATCH v2 4/9] memory: Don't do topology update in memory finalize()

2021-07-28 Thread David Hildenbrand
On 28.07.21 15:56, Peter Xu wrote: On Wed, Jul 28, 2021 at 02:13:17PM +0200, David Hildenbrand wrote: On 27.07.21 18:02, Peter Xu wrote: On Tue, Jul 27, 2021 at 03:21:31PM +0200, David Hildenbrand wrote: On 23.07.21 21:34, Peter Xu wrote: Topology update could be wrongly triggered in memory r

Re: [PATCH v2 4/9] memory: Don't do topology update in memory finalize()

2021-07-28 Thread Peter Xu
On Wed, Jul 28, 2021 at 02:13:17PM +0200, David Hildenbrand wrote: > On 27.07.21 18:02, Peter Xu wrote: > > On Tue, Jul 27, 2021 at 03:21:31PM +0200, David Hildenbrand wrote: > > > On 23.07.21 21:34, Peter Xu wrote: > > > > Topology update could be wrongly triggered in memory region finalize() > >

Re: [PATCH v2 4/9] memory: Don't do topology update in memory finalize()

2021-07-28 Thread David Hildenbrand
On 27.07.21 18:02, Peter Xu wrote: On Tue, Jul 27, 2021 at 03:21:31PM +0200, David Hildenbrand wrote: On 23.07.21 21:34, Peter Xu wrote: Topology update could be wrongly triggered in memory region finalize() if there's bug somewhere else. It'll be a very confusing stack when it happens (e.g.,

Re: [PATCH v2 4/9] memory: Don't do topology update in memory finalize()

2021-07-27 Thread Peter Xu
On Tue, Jul 27, 2021 at 03:21:31PM +0200, David Hildenbrand wrote: > On 23.07.21 21:34, Peter Xu wrote: > > Topology update could be wrongly triggered in memory region finalize() if > > there's bug somewhere else. It'll be a very confusing stack when it > > happens (e.g., sending KVM ioctl within

Re: [PATCH v2 4/9] memory: Don't do topology update in memory finalize()

2021-07-27 Thread David Hildenbrand
On 23.07.21 21:34, Peter Xu wrote: Topology update could be wrongly triggered in memory region finalize() if there's bug somewhere else. It'll be a very confusing stack when it happens (e.g., sending KVM ioctl within the RCU thread, and we'll observe it only until it fails!). Instead of that, w

[PATCH v2 4/9] memory: Don't do topology update in memory finalize()

2021-07-23 Thread Peter Xu
Topology update could be wrongly triggered in memory region finalize() if there's bug somewhere else. It'll be a very confusing stack when it happens (e.g., sending KVM ioctl within the RCU thread, and we'll observe it only until it fails!). Instead of that, we use the push()/pop() helper to avoi