John Snow writes:
[...]
> (Random aside on patch submission process: I do dislike how when I
> change the topic of a commit, I lose out on git-backport-diff
> functionality. I wish I had a persistent ID for commits that survived
> beyond title changes. Sometimes I debate scripting adding some k
On 4/16/21 2:17 AM, Markus Armbruster wrote:
John Snow writes:
On 4/15/21 3:00 AM, Markus Armbruster wrote:
John Snow writes:
On 3/30/21 1:18 PM, John Snow wrote:
Realizing now that this commit topic is wrong :)
A prior version modified the assertion, I decided it was less churn to
simpl
John Snow writes:
> On 4/15/21 3:00 AM, Markus Armbruster wrote:
>> John Snow writes:
>>
>>> On 3/30/21 1:18 PM, John Snow wrote:
>>>
>>> Realizing now that this commit topic is wrong :)
>>>
>>> A prior version modified the assertion, I decided it was less churn to
>>> simply add one.
>>>
>>> I
On 4/15/21 3:00 AM, Markus Armbruster wrote:
John Snow writes:
On 3/30/21 1:18 PM, John Snow wrote:
Realizing now that this commit topic is wrong :)
A prior version modified the assertion, I decided it was less churn to
simply add one.
I think ideally we'd have no assertions here and we'd r
John Snow writes:
> On 3/30/21 1:18 PM, John Snow wrote:
>
> Realizing now that this commit topic is wrong :)
>
> A prior version modified the assertion, I decided it was less churn to
> simply add one.
>
> I think ideally we'd have no assertions here and we'd rely on the type
> hints, but I do
On 3/30/21 1:18 PM, John Snow wrote:
Realizing now that this commit topic is wrong :)
A prior version modified the assertion, I decided it was less churn to
simply add one.
I think ideally we'd have no assertions here and we'd rely on the type
hints, but I don't think I can prove that this i
Eventually, we'll be able to prove that 'info.line' must be an int and
is never None at static analysis time, and this assert can go
away. Until then, it's a type error to assume that self.info is not
None.
Signed-off-by: John Snow
---
scripts/qapi/error.py | 1 +
1 file changed, 1 insertion(+)
