Re: [PATCH v2 4/5] libvhost-user: prevent over-running max RAM slots

2022-01-10 Thread Raphael Norwitz
On Mon, Jan 10, 2022 at 04:40:08AM -0500, Michael S. Tsirkin wrote: > On Thu, Jan 06, 2022 at 06:47:35AM +, Raphael Norwitz wrote: > > When VHOST_USER_PROTOCOL_F_CONFIGURE_MEM_SLOTS support was added to > > libvhost-user, no guardrails were added to protect against QEMU > > attempting to hot-ad

Re: [PATCH v2 4/5] libvhost-user: prevent over-running max RAM slots

2022-01-10 Thread Stefan Hajnoczi
On Thu, Jan 06, 2022 at 06:47:35AM +, Raphael Norwitz wrote: > When VHOST_USER_PROTOCOL_F_CONFIGURE_MEM_SLOTS support was added to > libvhost-user, no guardrails were added to protect against QEMU > attempting to hot-add too many RAM slots to a VM with a libvhost-user > based backed attached. >

Re: [PATCH v2 4/5] libvhost-user: prevent over-running max RAM slots

2022-01-10 Thread Michael S. Tsirkin
On Thu, Jan 06, 2022 at 06:47:35AM +, Raphael Norwitz wrote: > When VHOST_USER_PROTOCOL_F_CONFIGURE_MEM_SLOTS support was added to > libvhost-user, no guardrails were added to protect against QEMU > attempting to hot-add too many RAM slots to a VM with a libvhost-user > based backed attached. >

Re: [PATCH v2 4/5] libvhost-user: prevent over-running max RAM slots

2022-01-10 Thread David Hildenbrand
On 06.01.22 07:47, Raphael Norwitz wrote: > When VHOST_USER_PROTOCOL_F_CONFIGURE_MEM_SLOTS support was added to > libvhost-user, no guardrails were added to protect against QEMU > attempting to hot-add too many RAM slots to a VM with a libvhost-user > based backed attached. > > This change adds th

[PATCH v2 4/5] libvhost-user: prevent over-running max RAM slots

2022-01-05 Thread Raphael Norwitz
When VHOST_USER_PROTOCOL_F_CONFIGURE_MEM_SLOTS support was added to libvhost-user, no guardrails were added to protect against QEMU attempting to hot-add too many RAM slots to a VM with a libvhost-user based backed attached. This change adds the missing error handling by introducing a check on the