Re: [PATCH v2 4/4] target/i386: Update CMPLegacy handling for Zhaoxin CPUs

2024-08-08 Thread Ewan Hai
On 8/8/24 23:47, Zhao Liu wrote: On Thu, Aug 08, 2024 at 11:25:45PM -0400, Ewan Hai wrote: [snip] Thank you for your suggestion; the changes will indeed make it clearer. I have a question: since you’ve already added your reviewed-by tag to the first three patches, if I want to modify these des

Re: [PATCH v2 4/4] target/i386: Update CMPLegacy handling for Zhaoxin CPUs

2024-08-08 Thread Zhao Liu
On Thu, Aug 08, 2024 at 11:25:45PM -0400, Ewan Hai wrote: [snip] > Thank you for your suggestion; the changes will indeed make it clearer. > I have a question: since you’ve already added your reviewed-by tag to > the first three patches, if I want to modify these descriptions, should > I submit a

Re: [PATCH v2 4/4] target/i386: Update CMPLegacy handling for Zhaoxin CPUs

2024-08-08 Thread Ewan Hai
On 8/8/24 23:22, Zhao Liu wrote: Hi EwanHai, On Thu, Jul 04, 2024 at 07:25:11AM -0400, EwanHai wrote: Date: Thu, 4 Jul 2024 07:25:11 -0400 From: EwanHai Subject: [PATCH v2 4/4] target/i386: Update CMPLegacy handling for Zhaoxin CPUs X-Mailer: git-send-email 2.34.1 Zhaoxin CPUs handle

Re: [PATCH v2 4/4] target/i386: Update CMPLegacy handling for Zhaoxin CPUs

2024-08-08 Thread Zhao Liu
On Thu, Aug 08, 2024 at 09:44:18PM -0400, Ewan Hai wrote: > Date: Thu, 8 Aug 2024 21:44:18 -0400 > From: Ewan Hai > Subject: Re: [PATCH v2 4/4] target/i386: Update CMPLegacy handling for > Zhaoxin CPUs > > > Hi Zhao Liu, > > Thank you for your feedback. > >

Re: [PATCH v2 4/4] target/i386: Update CMPLegacy handling for Zhaoxin CPUs

2024-08-08 Thread Ewan Hai
Hi Zhao Liu, Thank you for your feedback. On 8/8/24 06:30, Zhao Liu wrote: Hi EwanHai, On Thu, Jul 04, 2024 at 07:25:11AM -0400, EwanHai wrote: Date: Thu, 4 Jul 2024 07:25:11 -0400 From: EwanHai Subject: [PATCH v2 4/4] target/i386: Update CMPLegacy handling for Zhaoxin CPUs X-Mailer

Re: [PATCH v2 4/4] target/i386: Update CMPLegacy handling for Zhaoxin CPUs

2024-08-08 Thread Zhao Liu
Hi EwanHai, On Thu, Jul 04, 2024 at 07:25:11AM -0400, EwanHai wrote: > Date: Thu, 4 Jul 2024 07:25:11 -0400 > From: EwanHai > Subject: [PATCH v2 4/4] target/i386: Update CMPLegacy handling for Zhaoxin > CPUs > X-Mailer: git-send-email 2.34.1 > > Zhaoxin CPUs handle the

[PATCH v2 4/4] target/i386: Update CMPLegacy handling for Zhaoxin CPUs

2024-07-04 Thread EwanHai
Zhaoxin CPUs handle the CMPLegacy bit in the same way as Intel CPUs. This patch simplifies the existing logic by using the IS_XXX_CPU macro and includes checks for Zhaoxin vendor to align their behavior with Intel. Signed-off-by: EwanHai --- target/i386/cpu.c | 4 +--- 1 file changed, 1 insertio