Re: [PATCH v2 4/4] hw/xen: Have Xen machines select 9pfs

2021-02-01 Thread Philippe Mathieu-Daudé
On 2/1/21 11:23 AM, Paolo Bonzini wrote: > On 01/02/21 10:18, Philippe Mathieu-Daudé wrote: >> FYI using 'imply FSDEV_9P' instead I get: >> >> /usr/bin/ld: libcommon.fa.p/hw_xen_xen-legacy-backend.c.o: in function >> `xen_be_register_common': >> hw/xen/xen-legacy-backend.c:754: undefined reference

Re: [PATCH v2 4/4] hw/xen: Have Xen machines select 9pfs

2021-02-01 Thread Paolo Bonzini
On 01/02/21 10:18, Philippe Mathieu-Daudé wrote: FYI using 'imply FSDEV_9P' instead I get: /usr/bin/ld: libcommon.fa.p/hw_xen_xen-legacy-backend.c.o: in function `xen_be_register_common': hw/xen/xen-legacy-backend.c:754: undefined reference to `xen_9pfs_ops' Ok, so then we have the case of a f

Re: [PATCH v2 4/4] hw/xen: Have Xen machines select 9pfs

2021-02-01 Thread Philippe Mathieu-Daudé
On 2/1/21 9:34 AM, Paolo Bonzini wrote: > On 31/01/21 15:18, Philippe Mathieu-Daudé wrote: >> 9pfs is not an accelerator feature but a machine one, >> move the selection on the machine Kconfig (in hw/). >> >> Signed-off-by: Philippe Mathieu-Daudé >> --- >>   accel/Kconfig   | 1 - >>   hw/i386/

Re: [PATCH v2 4/4] hw/xen: Have Xen machines select 9pfs

2021-02-01 Thread Paolo Bonzini
On 31/01/21 15:18, Philippe Mathieu-Daudé wrote: 9pfs is not an accelerator feature but a machine one, move the selection on the machine Kconfig (in hw/). Signed-off-by: Philippe Mathieu-Daudé --- accel/Kconfig | 1 - hw/i386/xen/Kconfig | 1 + hw/xen/Kconfig | 1 + 3 files chan

[PATCH v2 4/4] hw/xen: Have Xen machines select 9pfs

2021-01-31 Thread Philippe Mathieu-Daudé
9pfs is not an accelerator feature but a machine one, move the selection on the machine Kconfig (in hw/). Signed-off-by: Philippe Mathieu-Daudé --- accel/Kconfig | 1 - hw/i386/xen/Kconfig | 1 + hw/xen/Kconfig | 1 + 3 files changed, 2 insertions(+), 1 deletion(-) diff --git a/accel