Re: [PATCH v2 4/4] hw/display/artist.c: fix out of bounds check

2020-08-03 Thread Helge Deller
On 03.08.20 21:10, Alexander Bulekov wrote: > On 200803 1432, Alexander Bulekov wrote: >> On 200803 1336, Alexander Bulekov wrote: >>> Hi, >>> I applied this patch, but I can still trigger a segfault and heap >>> overread through artist_reg_write -> fill_window. I dont know if these >>> problems ar

Re: [PATCH v2 4/4] hw/display/artist.c: fix out of bounds check

2020-08-03 Thread Alexander Bulekov
On 200803 1432, Alexander Bulekov wrote: > On 200803 1336, Alexander Bulekov wrote: > > Hi, > > I applied this patch, but I can still trigger a segfault and heap > > overread through artist_reg_write -> fill_window. I dont know if these > > problems are related to what this patch fixes. If not, let

Re: [PATCH v2 4/4] hw/display/artist.c: fix out of bounds check

2020-08-03 Thread Alexander Bulekov
On 200803 1336, Alexander Bulekov wrote: > Hi, > I applied this patch, but I can still trigger a segfault and heap > overread through artist_reg_write -> fill_window. I dont know if these > problems are related to what this patch fixes. If not, let me know and > I can create a separate launchpad re

Re: [PATCH v2 4/4] hw/display/artist.c: fix out of bounds check

2020-08-03 Thread Alexander Bulekov
Hi, I applied this patch, but I can still trigger a segfault and heap overread through artist_reg_write -> fill_window. I dont know if these problems are related to what this patch fixes. If not, let me know and I can create a separate launchpad report for these. -Alex (1) Segfault: cat << EOF |

Re: [PATCH v2 4/4] hw/display/artist.c: fix out of bounds check

2020-08-03 Thread Richard Henderson
On 8/1/20 6:13 AM, Helge Deller wrote: > From: Sven Schnelle > > Signed-off-by: Sven Schnelle > Signed-off-by: Helge Deller > --- > hw/display/artist.c | 24 +++- > 1 file changed, 11 insertions(+), 13 deletions(-) Looks ok, if not ideal. Reviewed-by: Richard Henderson

[PATCH v2 4/4] hw/display/artist.c: fix out of bounds check

2020-08-01 Thread Helge Deller
From: Sven Schnelle Signed-off-by: Sven Schnelle Signed-off-by: Helge Deller --- hw/display/artist.c | 24 +++- 1 file changed, 11 insertions(+), 13 deletions(-) diff --git a/hw/display/artist.c b/hw/display/artist.c index 6261bfe65b..de56200dbf 100644 --- a/hw/display/art