Re: [PATCH v2 39/53] migration/rdma: Convert qemu_rdma_write_flush() to Error

2023-10-04 Thread Juan Quintela
Markus Armbruster wrote: > Functions that use an Error **errp parameter to return errors should > not also report them to the user, because reporting is the caller's > job. When the caller does, the error is reported twice. When it > doesn't (because it recovered from the error), there is no err

[PATCH v2 39/53] migration/rdma: Convert qemu_rdma_write_flush() to Error

2023-09-28 Thread Markus Armbruster
Functions that use an Error **errp parameter to return errors should not also report them to the user, because reporting is the caller's job. When the caller does, the error is reported twice. When it doesn't (because it recovered from the error), there is no error to report, i.e. the report is b