Re: [PATCH v2 31/39] util/log: Remove qemu_log_close

2022-04-14 Thread Alex Bennée
Richard Henderson writes: > The only real use is in cpu_abort, where we have just > flushed the file via qemu_log_unlock, and are just about > to force-crash the application via abort. We do not > really need to close the FILE before the abort. > > The two uses in test-logging.c can be handled

[PATCH v2 31/39] util/log: Remove qemu_log_close

2022-03-26 Thread Richard Henderson
The only real use is in cpu_abort, where we have just flushed the file via qemu_log_unlock, and are just about to force-crash the application via abort. We do not really need to close the FILE before the abort. The two uses in test-logging.c can be handled with qemu_set_log_filename_flags. Signe