Re: [PATCH v2 3/4] ui/cocoa: Add cursor composition

I've just tried to rebase my own patches on top of this work and noticed the following typo: On Thu, 27 Jun 2024 at 13:17, Akihiko Odaki wrote: > static void cocoa_refresh(DisplayChangeListener *dcl); > +static void cocoa_mouse_set(DisplayChangeListener *dcl, int x, int y, int > on); The abov

Re: [PATCH v2 3/4] ui/cocoa: Add cursor composition

On 2/7/24 16:25, Phil Dennis-Jordan wrote: On Tue, 2 Jul 2024 at 16:20, Philippe Mathieu-Daudé > wrote: Hi Phil, On 2/7/24 15:19, Phil Dennis-Jordan wrote: > I'm still keen on NSCursor support for absolute pointing mode though, so > I can expe

Re: [PATCH v2 3/4] ui/cocoa: Add cursor composition

Hi Phil, On 2/7/24 15:19, Phil Dennis-Jordan wrote: I'm still keen on NSCursor support for absolute pointing mode though, so I can experiment with doing a better job of cleaning it up as part v3 of that patch series. Do we need a v3, or can you clean on top? Regards, Phil :)

Re: [PATCH v2 3/4] ui/cocoa: Add cursor composition

On Tue, 2 Jul 2024 at 16:20, Philippe Mathieu-Daudé wrote: > Hi Phil, > > On 2/7/24 15:19, Phil Dennis-Jordan wrote: > > > I'm still keen on NSCursor support for absolute pointing mode though, so > > I can experiment with doing a better job of cleaning it up as part v3 of > > that patch series. >

Re: [PATCH v2 3/4] ui/cocoa: Add cursor composition

On Thu, 27 Jun 2024 at 13:17, Akihiko Odaki wrote: > Co-authored-by: Phil Dennis-Jordan > Signed-off-by: Akihiko Odaki > > +- (void)setCursor:(QEMUCursor *)given_cursor > +{ > +[…] > + > +provider = CGDataProviderCreateWithData( > +NULL, > +cursor->data, > +curso

[PATCH v2 3/4] ui/cocoa: Add cursor composition

Add accelerated cursor composition to ui/cocoa. This does not only improve performance for display devices that exposes the capability to the guest according to dpy_cursor_define_supported(), but fixes the cursor display for devices that unconditionally expects the availability of the capability (e