Re: [PATCH v2 3/3] tests/acpi: pc: update golden masters for DSDT

2024-11-04 Thread Michael S. Tsirkin
On Mon, Nov 04, 2024 at 03:00:00PM +0100, Ricardo Ribalda wrote: > Hi Michael > > > > On Mon, 4 Nov 2024 at 14:46, Michael S. Tsirkin wrote: > > > > On Tue, Sep 24, 2024 at 01:24:12PM +, Ricardo Ribalda wrote: > > > Signed-off-by: Ricardo Ribalda > > > > > > two things wrong here: > > 1. y

Re: [PATCH v2 3/3] tests/acpi: pc: update golden masters for DSDT

2024-11-04 Thread Ricardo Ribalda
Hi Michael On Mon, 4 Nov 2024 at 14:46, Michael S. Tsirkin wrote: > > On Tue, Sep 24, 2024 at 01:24:12PM +, Ricardo Ribalda wrote: > > Signed-off-by: Ricardo Ribalda > > > two things wrong here: > 1. you do not describe what changed in the ASL in the commit log In the cover page I mention

Re: [PATCH v2 3/3] tests/acpi: pc: update golden masters for DSDT

2024-11-04 Thread Michael S. Tsirkin
On Tue, Sep 24, 2024 at 01:24:12PM +, Ricardo Ribalda wrote: > Signed-off-by: Ricardo Ribalda two things wrong here: 1. you do not describe what changed in the ASL in the commit log 2. you forgot one DSDT: tests/data/acpi/x86/q35/DSDT.acpihmat-generic-x > --- > tests/data/acpi/x86/pc/DSDT

Re: [PATCH v2 3/3] tests/acpi: pc: update golden masters for DSDT

2024-09-24 Thread Igor Mammedov
On Tue, 24 Sep 2024 13:24:12 + Ricardo Ribalda wrote: > Signed-off-by: Ricardo Ribalda Acked-by: Igor Mammedov > --- > tests/data/acpi/x86/pc/DSDT | Bin 8527 -> 8526 bytes > tests/data/acpi/x86/pc/DSDT.acpierst| Bin 8438 -> 8437 bytes > tests/data/acpi/x86/pc/DS

[PATCH v2 3/3] tests/acpi: pc: update golden masters for DSDT

2024-09-24 Thread Ricardo Ribalda
Signed-off-by: Ricardo Ribalda --- tests/data/acpi/x86/pc/DSDT | Bin 8527 -> 8526 bytes tests/data/acpi/x86/pc/DSDT.acpierst| Bin 8438 -> 8437 bytes tests/data/acpi/x86/pc/DSDT.acpihmat| Bin 9852 -> 9851 bytes tests/data/acpi/x86/pc/DSDT.bridge | Bin 15

Re: [PATCH v2 3/3] tests/acpi: pc: update golden masters for DSDT

2024-06-07 Thread Michael S. Tsirkin
On Fri, Jun 07, 2024 at 08:58:58AM +, Ricardo Ribalda wrote: > --- /tmp/asl-87N0O2.dsl 2024-06-07 07:20:54.081576394 + > +++ /tmp/asl-4Q0YO2.dsl 2024-06-07 07:20:54.077576397 + > @@ -1,30 +1,30 @@ > /* > * Intel ACPI Component Architecture > * AML/ASL+ Disassembler vers

[PATCH v2 3/3] tests/acpi: pc: update golden masters for DSDT

2024-06-07 Thread Ricardo Ribalda
--- /tmp/asl-87N0O2.dsl 2024-06-07 07:20:54.081576394 + +++ /tmp/asl-4Q0YO2.dsl 2024-06-07 07:20:54.077576397 + @@ -1,30 +1,30 @@ /* * Intel ACPI Component Architecture * AML/ASL+ Disassembler version 20230628 (64-bit version) * Copyright (c) 2000 - 2023 Intel Corporation * * Dis