Re: [PATCH v2 3/3] target/mips: implement Octeon-specific arithmetic instructions

2022-06-13 Thread Pavel Dovgalyuk
On 09.06.2022 18:53, Richard Henderson wrote: On 6/9/22 01:23, Pavel Dovgalyuk wrote: +static bool trans_BADDU(DisasContext *ctx, arg_BADDU *a) +{ +    TCGv t0, t1; + +    if (a->rt == 0) { +    /* nop */ +    return true; +    } I believe that we're standardizing on using gen_store_gp

Re: [PATCH v2 3/3] target/mips: implement Octeon-specific arithmetic instructions

2022-06-09 Thread Richard Henderson
On 6/9/22 01:23, Pavel Dovgalyuk wrote: +static bool trans_BADDU(DisasContext *ctx, arg_BADDU *a) +{ +TCGv t0, t1; + +if (a->rt == 0) { +/* nop */ +return true; +} I believe that we're standardizing on using gen_store_gpr, and not checking for r0 everywhere. +sta

[PATCH v2 3/3] target/mips: implement Octeon-specific arithmetic instructions

2022-06-09 Thread Pavel Dovgalyuk
This patch implements several Octeon-specific instructions: - BADDU - DMUL - EXTS/EXTS32 - CINS/CINS32 - POP/DPOP - SEQ/SEQI - SNE/SNEI Signed-off-by: Pavel Dovgalyuk -- v2 changes: - Using existing tcg instructions for exts, cins, pop (suggested by Richard Henderson) --- target/mips/t