Re: [PATCH v2 3/3] replay: do not build if TCG is not available

2020-10-13 Thread Claudio Fontana
On 10/13/20 10:05 AM, Paolo Bonzini wrote: > On 13/10/20 09:56, Claudio Fontana wrote: >> Hi Paolo, >> >> On 10/13/20 12:29 AM, Paolo Bonzini wrote: >>> On 12/10/20 23:45, Claudio Fontana wrote: +ctx = blk_get_aio_context(blk); +if (!replay_bh_schedule_oneshot_event(ctx, error_cal

Re: [PATCH v2 3/3] replay: do not build if TCG is not available

2020-10-13 Thread Paolo Bonzini
On 13/10/20 09:56, Claudio Fontana wrote: > Hi Paolo, > > On 10/13/20 12:29 AM, Paolo Bonzini wrote: >> On 12/10/20 23:45, Claudio Fontana wrote: >>> +ctx = blk_get_aio_context(blk); >>> +if (!replay_bh_schedule_oneshot_event(ctx, error_callback_bh, acb)) { >>> +/* regular case wit

Re: [PATCH v2 3/3] replay: do not build if TCG is not available

2020-10-13 Thread Claudio Fontana
Hi Paolo, On 10/13/20 12:29 AM, Paolo Bonzini wrote: > On 12/10/20 23:45, Claudio Fontana wrote: >> +ctx = blk_get_aio_context(blk); >> +if (!replay_bh_schedule_oneshot_event(ctx, error_callback_bh, acb)) { >> +/* regular case without replay */ >> +aio_bh_schedule_oneshot(c

Re: [PATCH v2 3/3] replay: do not build if TCG is not available

2020-10-12 Thread Paolo Bonzini
On 12/10/20 23:45, Claudio Fontana wrote: > +ctx = blk_get_aio_context(blk); > +if (!replay_bh_schedule_oneshot_event(ctx, error_callback_bh, acb)) { > +/* regular case without replay */ > +aio_bh_schedule_oneshot(ctx, error_callback_bh, acb); > +} Why can't the stub ju

[PATCH v2 3/3] replay: do not build if TCG is not available

2020-10-12 Thread Claudio Fontana
this fixes non-TCG builds broken recently by replay reverse debugging. stub the needed functions in stub/, including errors for hmp and qmp. change hooks for the case when replay code is disabled (!CONFIG_TCG), as we need to avoid sinking all the events in replay in this case. Surprisingly, only