Re: [PATCH v2 29/38] qapi/gen.py: delint with pylint

2020-09-24 Thread Cleber Rosa
On Tue, Sep 22, 2020 at 05:00:52PM -0400, John Snow wrote: > 'fp' and 'fd' are self-evident in context, add them to the list of OK > names. > > _top and _bottom also need to stay class methods because some users > override the method and need to use `self`. Tell pylint to shush. > > Signed-off-by

Re: [PATCH v2 29/38] qapi/gen.py: delint with pylint

2020-09-23 Thread John Snow
On 9/23/20 11:44 AM, Eduardo Habkost wrote: On Tue, Sep 22, 2020 at 05:00:52PM -0400, John Snow wrote: 'fp' and 'fd' are self-evident in context, add them to the list of OK names. _top and _bottom also need to stay class methods because some users override the method and need to use `self`. Tel

Re: [PATCH v2 29/38] qapi/gen.py: delint with pylint

2020-09-23 Thread Eduardo Habkost
On Tue, Sep 22, 2020 at 05:00:52PM -0400, John Snow wrote: > 'fp' and 'fd' are self-evident in context, add them to the list of OK > names. > > _top and _bottom also need to stay class methods because some users > override the method and need to use `self`. Tell pylint to shush. Do you mean "stay

[PATCH v2 29/38] qapi/gen.py: delint with pylint

2020-09-22 Thread John Snow
'fp' and 'fd' are self-evident in context, add them to the list of OK names. _top and _bottom also need to stay class methods because some users override the method and need to use `self`. Tell pylint to shush. Signed-off-by: John Snow --- scripts/qapi/gen.py | 2 ++ scripts/qapi/pylintrc | 5