Re: [PATCH v2 28/33] spapr: Remove SpaprIrq::init_kvm hook

2019-09-29 Thread Cédric Le Goater
On 27/09/2019 07:50, David Gibson wrote: > This hook is a bit odd. The only caller is spapr_irq_init_kvm(), but > it explicitly takes an SpaprIrq *, so it's never really called through the > current SpaprIrq. Essentially this is just a way of passing through a > function pointer so that spapr_irq

Re: [PATCH v2 28/33] spapr: Remove SpaprIrq::init_kvm hook

2019-09-27 Thread Greg Kurz
On Fri, 27 Sep 2019 15:50:23 +1000 David Gibson wrote: > This hook is a bit odd. The only caller is spapr_irq_init_kvm(), but > it explicitly takes an SpaprIrq *, so it's never really called through the > current SpaprIrq. Essentially this is just a way of passing through a > function pointer s

[PATCH v2 28/33] spapr: Remove SpaprIrq::init_kvm hook

2019-09-26 Thread David Gibson
This hook is a bit odd. The only caller is spapr_irq_init_kvm(), but it explicitly takes an SpaprIrq *, so it's never really called through the current SpaprIrq. Essentially this is just a way of passing through a function pointer so that spapr_irq_init_kvm() can handle some configuration and err