Re: [PATCH v2 24/24] configure: automatically parse command line for meson -D options

2021-10-13 Thread Thomas Huth
On 13/10/2021 19.00, Paolo Bonzini wrote: On 13/10/21 13:27, Thomas Huth wrote: +def fixup_options(options): +    # Meson <= 0.60 does not include the choices in array options, fix that up +    for opt in options: +    if opt["name"] == "trace_backends": +    opt["choices"] = [ + 

Re: [PATCH v2 24/24] configure: automatically parse command line for meson -D options

2021-10-13 Thread Paolo Bonzini
On 13/10/21 13:27, Thomas Huth wrote: +def fixup_options(options): +    # Meson <= 0.60 does not include the choices in array options, fix that up +    for opt in options: +    if opt["name"] == "trace_backends": +    opt["choices"] = [ +    "dtrace", +    "

Re: [PATCH v2 24/24] configure: automatically parse command line for meson -D options

2021-10-13 Thread Thomas Huth
On 13/10/2021 13.11, Paolo Bonzini wrote: On 13/10/21 09:43, Paolo Bonzini wrote: On 12/10/21 20:15, Thomas Huth wrote: Old output with --help:   --enable-trace-backend=B Set trace backend     Available backends: nop, dtrace, ftrace, simple, stderr, ust New output:

Re: [PATCH v2 24/24] configure: automatically parse command line for meson -D options

2021-10-13 Thread Paolo Bonzini
On 13/10/21 09:43, Paolo Bonzini wrote: On 12/10/21 20:15, Thomas Huth wrote: Old output with --help:   --enable-trace-backend=B Set trace backend     Available backends: nop, dtrace, ftrace, simple, stderr, ust New output:    --enable-trace-backends=CHOICE

Re: [PATCH v2 24/24] configure: automatically parse command line for meson -D options

2021-10-13 Thread Paolo Bonzini
On 12/10/21 20:15, Thomas Huth wrote: Old output with --help:  --enable-trace-backend=B Set trace backend    Available backends: nop, dtrace, ftrace, simple, stderr, ust New output:   --enable-trace-backends=CHOICE    Set available tracing

Re: [PATCH v2 24/24] configure: automatically parse command line for meson -D options

2021-10-12 Thread Thomas Huth
On 12/10/2021 13.13, Paolo Bonzini wrote: Right now meson_options.txt lists about 90 options. Each option needs code in configure to parse it and pass the option down to Meson as a -D command-line argument; in addition the default must be duplicated between configure and meson_options.txt. This

[PATCH v2 24/24] configure: automatically parse command line for meson -D options

2021-10-12 Thread Paolo Bonzini
Right now meson_options.txt lists about 90 options. Each option needs code in configure to parse it and pass the option down to Meson as a -D command-line argument; in addition the default must be duplicated between configure and meson_options.txt. This series tries to remove the code duplication