Re: [PATCH v2 23/28] qapi tpm: Elide redundant has_FOO in generated C

2022-10-18 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > On Tue, 18 Oct 2022 at 14:12, Stefan Berger wrote: >> On 10/18/22 08:01, Philippe Mathieu-Daudé wrote: >> > On 18/10/22 08:28, Markus Armbruster wrote: >> >> The has_FOO for pointer-valued FOO are redundant, except for arrays. >> >> They are also a nuisance to wo

Re: [PATCH v2 23/28] qapi tpm: Elide redundant has_FOO in generated C

2022-10-18 Thread Philippe Mathieu-Daudé
On Tue, 18 Oct 2022 at 14:12, Stefan Berger wrote: > On 10/18/22 08:01, Philippe Mathieu-Daudé wrote: > > On 18/10/22 08:28, Markus Armbruster wrote: > >> The has_FOO for pointer-valued FOO are redundant, except for arrays. > >> They are also a nuisance to work with. Recent commit "qapi: Start to

Re: [PATCH v2 23/28] qapi tpm: Elide redundant has_FOO in generated C

2022-10-18 Thread Philippe Mathieu-Daudé
On 18/10/22 08:28, Markus Armbruster wrote: The has_FOO for pointer-valued FOO are redundant, except for arrays. They are also a nuisance to work with. Recent commit "qapi: Start to elide redundant has_FOO in generated C" provided the means to elide them step by step. This is the step for qapi/

Re: [PATCH v2 23/28] qapi tpm: Elide redundant has_FOO in generated C

2022-10-18 Thread Stefan Berger
On 10/18/22 08:01, Philippe Mathieu-Daudé wrote: On 18/10/22 08:28, Markus Armbruster wrote: The has_FOO for pointer-valued FOO are redundant, except for arrays. They are also a nuisance to work with.  Recent commit "qapi: Start to elide redundant has_FOO in generated C" provided the means to

[PATCH v2 23/28] qapi tpm: Elide redundant has_FOO in generated C

2022-10-17 Thread Markus Armbruster
The has_FOO for pointer-valued FOO are redundant, except for arrays. They are also a nuisance to work with. Recent commit "qapi: Start to elide redundant has_FOO in generated C" provided the means to elide them step by step. This is the step for qapi/tpm.json. Said commit explains the transforma