Re: [PATCH v2 20/55] accel/tcg: Report unaligned atomics for user-only

2021-08-18 Thread Richard Henderson
On 8/17/21 10:51 PM, Philippe Mathieu-Daudé wrote: -void *ret = g2h(env_cpu(env), addr); + +ret = g2h(env_cpu(env), addr); set_helper_retaddr(retaddr); return ret; Can't we simply do: return g2h(env_cpu(env), addr); ? I think the idea was to narrow the range of i

Re: [PATCH v2 20/55] accel/tcg: Report unaligned atomics for user-only

2021-08-18 Thread Philippe Mathieu-Daudé
Hi Richard, On 8/3/21 6:14 AM, Richard Henderson wrote: > Use the newly exposed cpu_unaligned_access for atomic_mmu_lookup, > which has access to complete alignment info from the TCGMemOpIdx arg. > > Signed-off-by: Richard Henderson > --- > accel/tcg/user-exec.c | 14 +- > 1 file ch

Re: [PATCH v2 20/55] accel/tcg: Report unaligned atomics for user-only

2021-08-03 Thread Alex Bennée
Richard Henderson writes: > Use the newly exposed cpu_unaligned_access for atomic_mmu_lookup, > which has access to complete alignment info from the TCGMemOpIdx arg. > > Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée > -void *ret = g2h(env_cpu(env), addr); > + > +ret = g

[PATCH v2 20/55] accel/tcg: Report unaligned atomics for user-only

2021-08-02 Thread Richard Henderson
Use the newly exposed cpu_unaligned_access for atomic_mmu_lookup, which has access to complete alignment info from the TCGMemOpIdx arg. Signed-off-by: Richard Henderson --- accel/tcg/user-exec.c | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/accel/tcg/user-exe