Re: [PATCH v2 2/9] tests/avocado: apply proper skipUnless decorator

2024-08-12 Thread Thomas Huth
On 06/08/2024 19.31, Cleber Rosa wrote: Commit 9b45cc993 added many cases of skipUnless for the sake of organizing flaky tests. But, Python decorators *must* follow what s/follow/directly precede/ ? Apart from that: Reviewed-by: Thomas Huth they decorate, so the newlines added should *not*

Re: [PATCH v2 2/9] tests/avocado: apply proper skipUnless decorator

2024-08-06 Thread Philippe Mathieu-Daudé
On 6/8/24 19:31, Cleber Rosa wrote: Commit 9b45cc993 added many cases of skipUnless for the sake of organizing flaky tests. But, Python decorators *must* follow what they decorate, so the newlines added should *not* exist there. Signed-off-by: Cleber Rosa --- tests/avocado/boot_linux_console

[PATCH v2 2/9] tests/avocado: apply proper skipUnless decorator

2024-08-06 Thread Cleber Rosa
Commit 9b45cc993 added many cases of skipUnless for the sake of organizing flaky tests. But, Python decorators *must* follow what they decorate, so the newlines added should *not* exist there. Signed-off-by: Cleber Rosa --- tests/avocado/boot_linux_console.py | 1 - tests/avocado/intel_iommu.py