Re: [PATCH v2 2/9] target/riscv: Don't overwrite the reset vector

2020-05-19 Thread Alistair Francis
On Sat, May 16, 2020 at 2:03 AM Bin Meng wrote: > > On Sat, May 16, 2020 at 3:51 AM Alistair Francis wrote: > > > > On Thu, May 14, 2020 at 9:54 PM Bin Meng wrote: > > > > > > On Fri, May 15, 2020 at 5:51 AM Alistair Francis > > > wrote: > > > > > > > > On Thu, May 14, 2020 at 10:54 AM Philipp

Re: [PATCH v2 2/9] target/riscv: Don't overwrite the reset vector

2020-05-16 Thread Bin Meng
On Sat, May 16, 2020 at 3:51 AM Alistair Francis wrote: > > On Thu, May 14, 2020 at 9:54 PM Bin Meng wrote: > > > > On Fri, May 15, 2020 at 5:51 AM Alistair Francis > > wrote: > > > > > > On Thu, May 14, 2020 at 10:54 AM Philippe Mathieu-Daudé > > > wrote: > > > > > > > > On 5/7/20 9:13 PM, Al

Re: [PATCH v2 2/9] target/riscv: Don't overwrite the reset vector

2020-05-15 Thread Alistair Francis
On Thu, May 14, 2020 at 9:54 PM Bin Meng wrote: > > On Fri, May 15, 2020 at 5:51 AM Alistair Francis wrote: > > > > On Thu, May 14, 2020 at 10:54 AM Philippe Mathieu-Daudé > > wrote: > > > > > > On 5/7/20 9:13 PM, Alistair Francis wrote: > > > > If the reset vector is set in the init function do

Re: [PATCH v2 2/9] target/riscv: Don't overwrite the reset vector

2020-05-14 Thread Bin Meng
On Fri, May 15, 2020 at 5:51 AM Alistair Francis wrote: > > On Thu, May 14, 2020 at 10:54 AM Philippe Mathieu-Daudé > wrote: > > > > On 5/7/20 9:13 PM, Alistair Francis wrote: > > > If the reset vector is set in the init function don't set it again in > > > realise. > > > > typo "realize". > > It

Re: [PATCH v2 2/9] target/riscv: Don't overwrite the reset vector

2020-05-14 Thread Alistair Francis
On Thu, May 14, 2020 at 10:54 AM Philippe Mathieu-Daudé wrote: > > On 5/7/20 9:13 PM, Alistair Francis wrote: > > If the reset vector is set in the init function don't set it again in > > realise. > > typo "realize". It's not a typo, just correct English :) I have changed it. > > > > > Signed-o

Re: [PATCH v2 2/9] target/riscv: Don't overwrite the reset vector

2020-05-14 Thread Philippe Mathieu-Daudé
On 5/7/20 9:13 PM, Alistair Francis wrote: If the reset vector is set in the init function don't set it again in realise. typo "realize". Signed-off-by: Alistair Francis --- target/riscv/cpu.c | 20 +++- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git a/targe

[PATCH v2 2/9] target/riscv: Don't overwrite the reset vector

2020-05-07 Thread Alistair Francis
If the reset vector is set in the init function don't set it again in realise. Signed-off-by: Alistair Francis --- target/riscv/cpu.c | 20 +++- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git a/target/riscv/cpu.c b/target/riscv/cpu.c index 059d71f2c7..8f837edf8d 100