Re: [PATCH v2 2/5] pci: Always pass own DeviceState to pci_map_irq_fn's

2022-02-13 Thread BALATON Zoltan
On Sun, 13 Feb 2022, Bernhard Beschow wrote: Am 12. Februar 2022 17:13:19 MEZ schrieb BALATON Zoltan : On Sat, 12 Feb 2022, Bernhard Beschow wrote: Am 12. Februar 2022 14:27:32 MEZ schrieb BALATON Zoltan : On Sat, 12 Feb 2022, Bernhard Beschow wrote: Passing own DeviceState rather than just t

Re: [PATCH v2 2/5] pci: Always pass own DeviceState to pci_map_irq_fn's

2022-02-13 Thread Bernhard Beschow
Am 12. Februar 2022 17:13:19 MEZ schrieb BALATON Zoltan : >On Sat, 12 Feb 2022, Bernhard Beschow wrote: >> Am 12. Februar 2022 14:27:32 MEZ schrieb BALATON Zoltan : >>> On Sat, 12 Feb 2022, Bernhard Beschow wrote: Passing own DeviceState rather than just the IRQs allows for resolving glob

Re: [PATCH v2 2/5] pci: Always pass own DeviceState to pci_map_irq_fn's

2022-02-12 Thread Peter Maydell
On Sat, 12 Feb 2022 at 13:27, BALATON Zoltan wrote: > > On Sat, 12 Feb 2022, Bernhard Beschow wrote: > > Passing own DeviceState rather than just the IRQs allows for resolving > > global variables. > > Do you mean pci_set_irq_fn instead of pci_map_irq_fn in the patch title? > > > Signed-off-by: Be

Re: [PATCH v2 2/5] pci: Always pass own DeviceState to pci_map_irq_fn's

2022-02-12 Thread BALATON Zoltan
On Sat, 12 Feb 2022, Bernhard Beschow wrote: Am 12. Februar 2022 14:27:32 MEZ schrieb BALATON Zoltan : On Sat, 12 Feb 2022, Bernhard Beschow wrote: Passing own DeviceState rather than just the IRQs allows for resolving global variables. Do you mean pci_set_irq_fn instead of pci_map_irq_fn in

Re: [PATCH v2 2/5] pci: Always pass own DeviceState to pci_map_irq_fn's

2022-02-12 Thread Bernhard Beschow
Am 12. Februar 2022 14:27:32 MEZ schrieb BALATON Zoltan : >On Sat, 12 Feb 2022, Bernhard Beschow wrote: >> Passing own DeviceState rather than just the IRQs allows for resolving >> global variables. > >Do you mean pci_set_irq_fn instead of pci_map_irq_fn in the patch title? I'm referring to the ty

Re: [PATCH v2 2/5] pci: Always pass own DeviceState to pci_map_irq_fn's

2022-02-12 Thread BALATON Zoltan
On Sat, 12 Feb 2022, Bernhard Beschow wrote: Passing own DeviceState rather than just the IRQs allows for resolving global variables. Do you mean pci_set_irq_fn instead of pci_map_irq_fn in the patch title? Signed-off-by: Bernhard Beschow Reviewed-by: Peter Maydell Reviewed-by: Philippe Mat

[PATCH v2 2/5] pci: Always pass own DeviceState to pci_map_irq_fn's

2022-02-12 Thread Bernhard Beschow
Passing own DeviceState rather than just the IRQs allows for resolving global variables. Signed-off-by: Bernhard Beschow Reviewed-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daudé --- hw/isa/piix4.c | 6 +++--- hw/pci-host/sh_pci.c| 6 +++--- hw/pci-host/versatile.c | 6 +++---