Re: [PATCH v2 2/4] linux-user/flatload: Take mmap_lock in load_flt_binary()

2024-10-06 Thread Richard Henderson
On 10/6/24 01:51, Michael Tokarev wrote: 22.08.2024 12:50, Philippe Mathieu-Daudé wrote: load_flt_binary() calls load_flat_file() -> page_set_flags(). page_set_flags() must be called with the mmap_lock held, otherwise it aborts:    $ qemu-arm -L stm32/lib/ stm32/bin/busybox    qemu-arm: ../acc

Re: [PATCH v2 2/4] linux-user/flatload: Take mmap_lock in load_flt_binary()

2024-10-06 Thread Michael Tokarev
22.08.2024 12:50, Philippe Mathieu-Daudé wrote: load_flt_binary() calls load_flat_file() -> page_set_flags(). page_set_flags() must be called with the mmap_lock held, otherwise it aborts: $ qemu-arm -L stm32/lib/ stm32/bin/busybox qemu-arm: ../accel/tcg/user-exec.c:505: page_set_flags: As

[PATCH v2 2/4] linux-user/flatload: Take mmap_lock in load_flt_binary()

2024-08-22 Thread Philippe Mathieu-Daudé
load_flt_binary() calls load_flat_file() -> page_set_flags(). page_set_flags() must be called with the mmap_lock held, otherwise it aborts: $ qemu-arm -L stm32/lib/ stm32/bin/busybox qemu-arm: ../accel/tcg/user-exec.c:505: page_set_flags: Assertion `have_mmap_lock()' failed. Aborted (core