Re: [PATCH v2 2/3] spapr: Use error_append_hint() in spapr_caps.c

2020-06-11 Thread Laurent Vivier
On 11/06/2020 12:44, Greg Kurz wrote: > On Thu, 11 Jun 2020 13:42:48 +0300 > Vladimir Sementsov-Ogievskiy wrote: > >> 11.06.2020 13:21, Vladimir Sementsov-Ogievskiy wrote: >>> 11.06.2020 13:13, Greg Kurz wrote: On Thu, 11 Jun 2020 11:50:57 +0200 Laurent Vivier wrote: > On 11/0

Re: [PATCH v2 2/3] spapr: Use error_append_hint() in spapr_caps.c

2020-06-11 Thread Vladimir Sementsov-Ogievskiy
11.06.2020 13:44, Vladimir Sementsov-Ogievskiy wrote: 11.06.2020 13:39, Greg Kurz wrote: On Thu, 11 Jun 2020 13:21:51 +0300 Vladimir Sementsov-Ogievskiy wrote: 11.06.2020 13:13, Greg Kurz wrote: On Thu, 11 Jun 2020 11:50:57 +0200 Laurent Vivier wrote: On 11/06/2020 11:10, Greg Kurz wrote:

Re: [PATCH v2 2/3] spapr: Use error_append_hint() in spapr_caps.c

2020-06-11 Thread Vladimir Sementsov-Ogievskiy
11.06.2020 13:39, Greg Kurz wrote: On Thu, 11 Jun 2020 13:21:51 +0300 Vladimir Sementsov-Ogievskiy wrote: 11.06.2020 13:13, Greg Kurz wrote: On Thu, 11 Jun 2020 11:50:57 +0200 Laurent Vivier wrote: On 11/06/2020 11:10, Greg Kurz wrote: We have a dedicated error API for hints. Use it inste

Re: [PATCH v2 2/3] spapr: Use error_append_hint() in spapr_caps.c

2020-06-11 Thread Greg Kurz
On Thu, 11 Jun 2020 13:42:48 +0300 Vladimir Sementsov-Ogievskiy wrote: > 11.06.2020 13:21, Vladimir Sementsov-Ogievskiy wrote: > > 11.06.2020 13:13, Greg Kurz wrote: > >> On Thu, 11 Jun 2020 11:50:57 +0200 > >> Laurent Vivier wrote: > >> > >>> On 11/06/2020 11:10, Greg Kurz wrote: > We have

Re: [PATCH v2 2/3] spapr: Use error_append_hint() in spapr_caps.c

2020-06-11 Thread Vladimir Sementsov-Ogievskiy
11.06.2020 13:21, Vladimir Sementsov-Ogievskiy wrote: 11.06.2020 13:13, Greg Kurz wrote: On Thu, 11 Jun 2020 11:50:57 +0200 Laurent Vivier wrote: On 11/06/2020 11:10, Greg Kurz wrote: We have a dedicated error API for hints. Use it instead of embedding the hint in the error message, as recom

Re: [PATCH v2 2/3] spapr: Use error_append_hint() in spapr_caps.c

2020-06-11 Thread Greg Kurz
On Thu, 11 Jun 2020 13:21:51 +0300 Vladimir Sementsov-Ogievskiy wrote: > 11.06.2020 13:13, Greg Kurz wrote: > > On Thu, 11 Jun 2020 11:50:57 +0200 > > Laurent Vivier wrote: > > > >> On 11/06/2020 11:10, Greg Kurz wrote: > >>> We have a dedicated error API for hints. Use it instead of embedding

Re: [PATCH v2 2/3] spapr: Use error_append_hint() in spapr_caps.c

2020-06-11 Thread Vladimir Sementsov-Ogievskiy
11.06.2020 13:21, Vladimir Sementsov-Ogievskiy wrote: 11.06.2020 13:13, Greg Kurz wrote: On Thu, 11 Jun 2020 11:50:57 +0200 Laurent Vivier wrote: On 11/06/2020 11:10, Greg Kurz wrote: We have a dedicated error API for hints. Use it instead of embedding the hint in the error message, as recom

Re: [PATCH v2 2/3] spapr: Use error_append_hint() in spapr_caps.c

2020-06-11 Thread Vladimir Sementsov-Ogievskiy
11.06.2020 13:13, Greg Kurz wrote: On Thu, 11 Jun 2020 11:50:57 +0200 Laurent Vivier wrote: On 11/06/2020 11:10, Greg Kurz wrote: We have a dedicated error API for hints. Use it instead of embedding the hint in the error message, as recommanded in the "qapi/error.h" header file. Since spapr_

Re: [PATCH v2 2/3] spapr: Use error_append_hint() in spapr_caps.c

2020-06-11 Thread Greg Kurz
On Thu, 11 Jun 2020 11:50:57 +0200 Laurent Vivier wrote: > On 11/06/2020 11:10, Greg Kurz wrote: > > We have a dedicated error API for hints. Use it instead of embedding > > the hint in the error message, as recommanded in the "qapi/error.h" > > header file. > > > > Since spapr_caps_apply() pass

Re: [PATCH v2 2/3] spapr: Use error_append_hint() in spapr_caps.c

2020-06-11 Thread Laurent Vivier
On 11/06/2020 11:10, Greg Kurz wrote: > We have a dedicated error API for hints. Use it instead of embedding > the hint in the error message, as recommanded in the "qapi/error.h" > header file. > > Since spapr_caps_apply() passes &error_fatal, all functions must > also call the ERRP_AUTO_PROPAGATE

Re: [PATCH v2 2/3] spapr: Use error_append_hint() in spapr_caps.c

2020-06-11 Thread Vladimir Sementsov-Ogievskiy
11.06.2020 12:10, Greg Kurz wrote: We have a dedicated error API for hints. Use it instead of embedding the hint in the error message, as recommanded in the "qapi/error.h" header file. Since spapr_caps_apply() passes &error_fatal, all functions must also call the ERRP_AUTO_PROPAGATE() macro for

[PATCH v2 2/3] spapr: Use error_append_hint() in spapr_caps.c

2020-06-11 Thread Greg Kurz
We have a dedicated error API for hints. Use it instead of embedding the hint in the error message, as recommanded in the "qapi/error.h" header file. Since spapr_caps_apply() passes &error_fatal, all functions must also call the ERRP_AUTO_PROPAGATE() macro for error_append_hint() to be functional.