Re: [PATCH v2 2/2] s390x/cpumodel: Introduce dynamic feature groups

2019-12-12 Thread David Hildenbrand
>> I think, you could if you would expand "best X" to something like >> >> -cpu X,all-features=off,featX=on,featY=on ... >> >> The "all-features" part would need a better name as discussed. Such a >> model would always have a defined feature set (all listed features) == >> static. The list could ge

Re: [PATCH v2 2/2] s390x/cpumodel: Introduce dynamic feature groups

2019-12-09 Thread Eduardo Habkost
On Thu, Dec 05, 2019 at 03:48:47PM +0100, David Hildenbrand wrote: > On 05.12.19 15:35, Eduardo Habkost wrote: > > On Mon, Dec 02, 2019 at 10:15:12AM +0100, David Hildenbrand wrote: > >> > Say the user has the option to select a model (zEC12, z13, z14), upper > layers always want to have

Re: [PATCH v2 2/2] s390x/cpumodel: Introduce dynamic feature groups

2019-12-05 Thread David Hildenbrand
On 05.12.19 15:35, Eduardo Habkost wrote: > On Mon, Dec 02, 2019 at 10:15:12AM +0100, David Hildenbrand wrote: >> Say the user has the option to select a model (zEC12, z13, z14), upper layers always want to have a model that includes all backported security features. While the host m

Re: [PATCH v2 2/2] s390x/cpumodel: Introduce dynamic feature groups

2019-12-05 Thread Eduardo Habkost
On Mon, Dec 02, 2019 at 10:15:12AM +0100, David Hildenbrand wrote: > > >> Say the user has the option to select a model (zEC12, z13, z14), upper > >> layers always want to have a model that includes all backported security > >> features. While the host model can do that, CPU definitions can't. You

Re: [PATCH v2 2/2] s390x/cpumodel: Introduce dynamic feature groups

2019-12-02 Thread David Hildenbrand
>> Say the user has the option to select a model (zEC12, z13, z14), upper >> layers always want to have a model that includes all backported security >> features. While the host model can do that, CPU definitions can't. You >> can't change default models within a QEMU release, or for older releas

Re: [PATCH v2 2/2] s390x/cpumodel: Introduce dynamic feature groups

2019-11-29 Thread Eduardo Habkost
On Tue, Nov 26, 2019 at 03:07:32PM +0100, David Hildenbrand wrote: > On 26.11.19 13:59, Christian Borntraeger wrote: > > re-adding ccs from the cover-letter > > > On 25.11.19 18:20, David Hildenbrand wrote: > > As soon as dynamic feature groups are used, the CPU model becomes >

Re: [PATCH v2 2/2] s390x/cpumodel: Introduce dynamic feature groups

2019-11-26 Thread David Hildenbrand
On 26.11.19 13:59, Christian Borntraeger wrote: > re-adding ccs from the cover-letter > On 25.11.19 18:20, David Hildenbrand wrote: As soon as dynamic feature groups are used, the CPU model becomes migration-unsafe. Upper layers can expand these models to migration-safe an

Re: [PATCH v2 2/2] s390x/cpumodel: Introduce dynamic feature groups

2019-11-26 Thread Christian Borntraeger
re-adding ccs from the cover-letter >>> On 25.11.19 18:20, David Hildenbrand wrote: >>> >>> As soon as dynamic feature groups are used, the CPU model becomes >>> migration-unsafe. Upper layers can expand these models to migration-safe >>> and static variants, allowing them to be migrated. >> >> I

Re: [PATCH v2 2/2] s390x/cpumodel: Introduce dynamic feature groups

2019-11-26 Thread David Hildenbrand
> Am 26.11.2019 um 08:54 schrieb Christian Borntraeger : > >  > >> On 25.11.19 18:20, David Hildenbrand wrote: >> >> As soon as dynamic feature groups are used, the CPU model becomes >> migration-unsafe. Upper layers can expand these models to migration-safe >> and static variants, allowing

Re: [PATCH v2 2/2] s390x/cpumodel: Introduce dynamic feature groups

2019-11-25 Thread Christian Borntraeger
On 25.11.19 18:20, David Hildenbrand wrote: > > As soon as dynamic feature groups are used, the CPU model becomes > migration-unsafe. Upper layers can expand these models to migration-safe > and static variants, allowing them to be migrated. I really dislike that. I am trying to get rid of the

[PATCH v2 2/2] s390x/cpumodel: Introduce dynamic feature groups

2019-11-25 Thread David Hildenbrand
For a specific CPU model, we have a lot of feature variability depending on - The microcode version of the HW - The hypervisor we're running on (LPAR vs. KVM vs. z/VM) - The hypervisor version we're running on - The KVM version - KVM module parameters (especially, "nested=1") - The accelerator Our