Re: [PATCH v2 2/2] migration/tls: add error handling in multifd_tls_handshake_thread

2021-03-06 Thread Zheng Chuan
Reviewed-by: Chuan Zheng On 2021/2/9 18:42, Hao Wang wrote: > If any error happens during multifd send thread creating (e.g. channel broke > because new domain is destroyed by the dst), multifd_tls_handshake_thread > may exit silently, leaving main migration thread hanging (ram_save_setup -> > mu

[PATCH v2 2/2] migration/tls: add error handling in multifd_tls_handshake_thread

2021-02-09 Thread Hao Wang
If any error happens during multifd send thread creating (e.g. channel broke because new domain is destroyed by the dst), multifd_tls_handshake_thread may exit silently, leaving main migration thread hanging (ram_save_setup -> multifd_send_sync_main -> qemu_sem_wait(&p->sem_sync)). Fix that by addi

Re: [PATCH v2 2/2] migration/tls: add error handling in multifd_tls_handshake_thread

2021-02-09 Thread Daniel P . Berrangé
On Tue, Feb 09, 2021 at 06:42:37PM +0800, Hao Wang wrote: > If any error happens during multifd send thread creating (e.g. channel broke > because new domain is destroyed by the dst), multifd_tls_handshake_thread > may exit silently, leaving main migration thread hanging (ram_save_setup -> > multif