Re: [PATCH v2 2/2] ide: Fix incorrect handling of some PRDTs in ide_dma_cb()

2020-01-01 Thread Alexander Popov
On 24.12.2019 07:18, Alexander Popov wrote: > On 24.12.2019 03:20, John Snow wrote: >> On 12/19/19 10:01 AM, Kevin Wolf wrote: >>> >>> John, what do you think? >>> >> >> I've been out to lunch for a little while. There are some issues that I >> recall with IDE, but couldn't find the time to fix pri

Re: [PATCH v2 2/2] ide: Fix incorrect handling of some PRDTs in ide_dma_cb()

2019-12-23 Thread Alexander Popov
On 24.12.2019 03:20, John Snow wrote: > On 12/19/19 10:01 AM, Kevin Wolf wrote: >> >> John, what do you think? >> > > I've been out to lunch for a little while. There are some issues that I > recall with IDE, but couldn't find the time to fix prior to 4.2. Hello John. > I'll review all the outst

Re: [PATCH v2 2/2] ide: Fix incorrect handling of some PRDTs in ide_dma_cb()

2019-12-23 Thread John Snow
On 12/19/19 10:01 AM, Kevin Wolf wrote: > Am 16.12.2019 um 19:14 hat Alexander Popov geschrieben: >> The commit a718978ed58a from July 2015 introduced the assertion which >> implies that the size of successful DMA transfers handled in ide_dma_cb() >> should be multiple of 512 (the size of a sect

Re: [PATCH v2 2/2] ide: Fix incorrect handling of some PRDTs in ide_dma_cb()

2019-12-19 Thread Alexander Popov
Hello Kevin! Thanks again for your review. On 19.12.2019 18:01, Kevin Wolf wrote: > Am 16.12.2019 um 19:14 hat Alexander Popov geschrieben: >> The commit a718978ed58a from July 2015 introduced the assertion which >> implies that the size of successful DMA transfers handled in ide_dma_cb() >> shou

Re: [PATCH v2 2/2] ide: Fix incorrect handling of some PRDTs in ide_dma_cb()

2019-12-19 Thread Kevin Wolf
Am 16.12.2019 um 19:14 hat Alexander Popov geschrieben: > The commit a718978ed58a from July 2015 introduced the assertion which > implies that the size of successful DMA transfers handled in ide_dma_cb() > should be multiple of 512 (the size of a sector). But guest systems can > initiate DMA transf

[PATCH v2 2/2] ide: Fix incorrect handling of some PRDTs in ide_dma_cb()

2019-12-16 Thread Alexander Popov
The commit a718978ed58a from July 2015 introduced the assertion which implies that the size of successful DMA transfers handled in ide_dma_cb() should be multiple of 512 (the size of a sector). But guest systems can initiate DMA transfers that don't fit this requirement. For fixing that let's chec